2016-10-27 21:01:04 +01:00
|
|
|
package test
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"io/ioutil"
|
|
|
|
|
"testing"
|
|
|
|
|
"time"
|
|
|
|
|
|
2019-02-17 15:31:32 +07:00
|
|
|
"github.com/coredns/coredns/plugin/test"
|
2017-03-02 19:35:44 +00:00
|
|
|
|
2016-10-27 21:01:04 +01:00
|
|
|
"github.com/miekg/dns"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestZoneReload(t *testing.T) {
|
2019-01-28 15:25:14 +08:00
|
|
|
name, rm, err := test.TempFile(".", exampleOrg)
|
2016-10-27 21:01:04 +01:00
|
|
|
if err != nil {
|
2017-03-02 19:35:44 +00:00
|
|
|
t.Fatalf("Failed to create zone: %s", err)
|
2016-10-27 21:01:04 +01:00
|
|
|
}
|
|
|
|
|
defer rm()
|
|
|
|
|
|
|
|
|
|
// Corefile with two stanzas
|
2020-04-25 14:08:36 +08:00
|
|
|
corefile := `
|
|
|
|
|
example.org:0 {
|
|
|
|
|
file ` + name + ` {
|
Speed up testing (#4239)
* Speed up testing
* make notification run in the background, this recudes the test_readme
time from 18s to 0.10s
* reduce time for zone reload
* TestServeDNSConcurrent remove entirely. This took a whopping 58s for
... ? A few minutes staring didn't reveal wth it is actually testing.
Making values smaller revealed race conditions in the tests. Remove
entirely.
* Move many interval values to variables so we can reset them to short
values for the tests.
* test_large_axfr: make the zone smaller. The number used 64K has no
rational, make it 64/10 to speed up.
* TestProxyThreeWay: use client with shorter timeout
A few random tidbits in other tests.
Total time saved: 177s (almost 3m) - which makes it worthwhile again to
run the test locally:
this branch:
~~~
ok github.com/coredns/coredns/test 10.437s
cd plugin; time go t ./...
5,51s user 7,51s system 11,15s elapsed 744%CPU (
~~~
master:
~~~
ok github.com/coredns/coredns/test 35.252s
cd plugin; time go t ./...
157,64s user 15,39s system 50,05s elapsed 345%CPU ()
~~~
tests/ -25s
plugins/ -40s
This brings the total on 20s, and another 10s can be saved by fixing
dnstapio. Moving this to 5s would be even better, but 10s is also nice.
Signed-off-by: Miek Gieben <miek@miek.nl>
* Also 0.01
Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-30 10:27:04 +01:00
|
|
|
reload 0.01s
|
2020-04-25 14:08:36 +08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
example.net:0 {
|
|
|
|
|
file ` + name + `
|
|
|
|
|
}`
|
2016-10-27 21:01:04 +01:00
|
|
|
|
2017-08-24 11:35:14 +01:00
|
|
|
i, udp, _, err := CoreDNSServerAndPorts(corefile)
|
2016-10-27 21:01:04 +01:00
|
|
|
if err != nil {
|
|
|
|
|
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
|
|
|
|
|
}
|
|
|
|
|
defer i.Stop()
|
|
|
|
|
|
2019-01-13 16:54:49 +00:00
|
|
|
m := new(dns.Msg)
|
|
|
|
|
m.SetQuestion("example.org.", dns.TypeA)
|
|
|
|
|
resp, err := dns.Exchange(m, udp)
|
2016-10-27 21:01:04 +01:00
|
|
|
if err != nil {
|
2017-03-02 19:35:44 +00:00
|
|
|
t.Fatalf("Expected to receive reply, but didn't: %s", err)
|
2016-10-27 21:01:04 +01:00
|
|
|
}
|
|
|
|
|
if len(resp.Answer) != 2 {
|
2016-10-28 12:59:18 +01:00
|
|
|
t.Fatalf("Expected two RR in answer section got %d", len(resp.Answer))
|
2016-10-27 21:01:04 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Remove RR from the Apex
|
|
|
|
|
ioutil.WriteFile(name, []byte(exampleOrgUpdated), 0644)
|
|
|
|
|
|
Speed up testing (#4239)
* Speed up testing
* make notification run in the background, this recudes the test_readme
time from 18s to 0.10s
* reduce time for zone reload
* TestServeDNSConcurrent remove entirely. This took a whopping 58s for
... ? A few minutes staring didn't reveal wth it is actually testing.
Making values smaller revealed race conditions in the tests. Remove
entirely.
* Move many interval values to variables so we can reset them to short
values for the tests.
* test_large_axfr: make the zone smaller. The number used 64K has no
rational, make it 64/10 to speed up.
* TestProxyThreeWay: use client with shorter timeout
A few random tidbits in other tests.
Total time saved: 177s (almost 3m) - which makes it worthwhile again to
run the test locally:
this branch:
~~~
ok github.com/coredns/coredns/test 10.437s
cd plugin; time go t ./...
5,51s user 7,51s system 11,15s elapsed 744%CPU (
~~~
master:
~~~
ok github.com/coredns/coredns/test 35.252s
cd plugin; time go t ./...
157,64s user 15,39s system 50,05s elapsed 345%CPU ()
~~~
tests/ -25s
plugins/ -40s
This brings the total on 20s, and another 10s can be saved by fixing
dnstapio. Moving this to 5s would be even better, but 10s is also nice.
Signed-off-by: Miek Gieben <miek@miek.nl>
* Also 0.01
Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-30 10:27:04 +01:00
|
|
|
time.Sleep(10 * time.Millisecond) // reload time
|
2016-10-27 21:01:04 +01:00
|
|
|
|
2019-01-13 16:54:49 +00:00
|
|
|
resp, err = dns.Exchange(m, udp)
|
2016-10-27 21:01:04 +01:00
|
|
|
if err != nil {
|
|
|
|
|
t.Fatal("Expected to receive reply, but didn't")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(resp.Answer) != 1 {
|
2016-10-28 12:59:18 +01:00
|
|
|
t.Fatalf("Expected two RR in answer section got %d", len(resp.Answer))
|
2016-10-27 21:01:04 +01:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const exampleOrgUpdated = `; example.org test file
|
|
|
|
|
example.org. IN SOA sns.dns.icann.org. noc.dns.icann.org. 2016082541 7200 3600 1209600 3600
|
|
|
|
|
example.org. IN NS b.iana-servers.net.
|
|
|
|
|
example.org. IN NS a.iana-servers.net.
|
|
|
|
|
example.org. IN A 127.0.0.2
|
|
|
|
|
`
|