From 0191ec74d8ccc88e56ea0503835fca27765b44d8 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 19 Aug 2017 14:53:52 +0100 Subject: [PATCH] Make it nodata --- middleware/kubernetes/handler_test.go | 7 +++++++ test/kubernetes_test.go | 7 ++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/middleware/kubernetes/handler_test.go b/middleware/kubernetes/handler_test.go index c01b17bcb..fe24a7255 100644 --- a/middleware/kubernetes/handler_test.go +++ b/middleware/kubernetes/handler_test.go @@ -45,6 +45,13 @@ var dnsTestCases = map[string](test.Case){ test.A("*.any.svc1.*.svc.cluster.local. 0 IN A 10.0.0.1"), }, }, + "SRV Service Not udp/tcp": { + Qname: "*._not-udp-or-tcp.svc1.testns.svc.cluster.local.", Qtype: dns.TypeSRV, + Rcode: dns.RcodeSuccess, + Ns: []dns.RR{ + test.SOA("cluster.local. 300 IN SOA ns.dns.cluster.local. hostmaster.cluster.local. 1499347823 7200 1800 86400 60"), + }, + }, "SRV Service": { Qname: "_http._tcp.svc1.testns.svc.cluster.local.", Qtype: dns.TypeSRV, Rcode: dns.RcodeSuccess, diff --git a/test/kubernetes_test.go b/test/kubernetes_test.go index c816115f6..870f55e9d 100644 --- a/test/kubernetes_test.go +++ b/test/kubernetes_test.go @@ -213,10 +213,11 @@ var dnsTestCases = []test.Case{ }, }, { - // TODO(miek): double check. Qname: "*._not-udp-or-tcp.svc-1-a.test-1.svc.cluster.local.", Qtype: dns.TypeSRV, - Rcode: dns.RcodeSuccess, - Answer: []dns.RR{}, + Rcode: dns.RcodeSuccess, + Ns: []dns.RR{ + test.SOA("cluster.local. 300 IN SOA ns.dns.cluster.local. hostmaster.cluster.local. 1499347823 7200 1800 86400 60"), + }, }, { Qname: "svc-1-a.test-1.svc.cluster.local.", Qtype: dns.TypeSRV,