Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/proxy: add note about HC and google_https (#1269)

Browse Source 
HC for google_https does not work because it does not HC the correct
set of IPs. Hard to solve in the current code - rather use forward as
the new impl. and leave this as legacy.

Remove superfluous println that we are refreshing the dns.google.com IP
address.
This commit is contained in:
Miek Gieben
2017-12-01 13:21:18 +00:00
committed by GitHub
parent 861e2382c2
commit 0d103ff57c
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugin/proxy/README.md
View File

@@ -188,3 +188,8 @@ example.org {
proxy . 8.8.8.8:53 proxy . 8.8.8.8:53
} }
~~~ ~~~
# Bugs
When using the `google_https` protocol the health checking will health check the wrong endpoint.
See <https://github.com/coredns/coredns/issues/1202> for some background.

2
plugin/proxy/google.go
View File

@@ -117,8 +117,6 @@ func (g *google) OnStartup(p *Proxy) error {
oldUpstream := (*p.Upstreams)[0] oldUpstream := (*p.Upstreams)[0]
log.Printf("[INFO] Bootstrapping A records %q", g.endpoint)
new, err := g.bootstrapProxy.Lookup(state, g.endpoint, dns.TypeA) new, err := g.bootstrapProxy.Lookup(state, g.endpoint, dns.TypeA)
if err != nil { if err != nil {
log.Printf("[WARNING] Failed to bootstrap A records %q: %s", g.endpoint, err) log.Printf("[WARNING] Failed to bootstrap A records %q: %s", g.endpoint, err)