Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-30 01:34:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(transfer): goroutine leak on axfr err (#7516)

Browse Source
This commit is contained in:
Ville Vesilehto
2025-09-05 23:13:11 +03:00
committed by GitHub
parent 8c2cfb01e3
commit 0dd76bd9b1
2 changed files with 68 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugin/transfer/transfer.go
View File

@@ -134,6 +134,11 @@ func (t *Transfer) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Ms
select {
case ch <- &dns.Envelope{RR: rrs}:
case err := <-errCh:
// Client errored; drain pchan to avoid blocking the producer goroutine.
go func() {
for range pchan {
}
}()
return dns.RcodeServerFailure, err
}
l += len(rrs)
@@ -161,11 +166,7 @@ func (t *Transfer) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Ms
}
if len(rrs) > 0 {
select {
case ch <- &dns.Envelope{RR: rrs}:
case err := <-errCh:
return dns.RcodeServerFailure, err
}
ch <- &dns.Envelope{RR: rrs}
l += len(rrs)
}