Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-05 19:46:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

middleware/file: notify better error reporting

Browse Source 
Slightly better errors reporting for failing to sent a notify.
This commit is contained in:
Miek Gieben
2016-11-08 21:45:27 +00:00
parent fb7fcff982
commit 0f8cb5094d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
middleware/file/notify.go
View File

@@ -56,10 +56,12 @@ func notify(zone string, to []string) error {
return nil return nil
} }
func notifyAddr(c *dns.Client, m *dns.Msg, s string) error { func notifyAddr(c *dns.Client, m *dns.Msg, s string) (err error) {
code := dns.RcodeSuccess ret := new(dns.Msg)
code := dns.RcodeServerFailure
for i := 0; i < 3; i++ { for i := 0; i < 3; i++ {
ret, _, err := c.Exchange(m, s) ret, _, err = c.Exchange(m, s)
if err != nil { if err != nil {
continue continue
} }
@@ -68,5 +70,8 @@ func notifyAddr(c *dns.Client, m *dns.Msg, s string) error {
return nil return nil
} }
} }
if err != nil {
return err
}
return fmt.Errorf("Notify for zone %q was not accepted by %q: rcode was %q", m.Question[0].Name, s, rcode.ToString(code)) return fmt.Errorf("Notify for zone %q was not accepted by %q: rcode was %q", m.Question[0].Name, s, rcode.ToString(code))
} }