Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-26 13:44:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup metrics (#3776)

Browse Source 
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.

Signed-off-by: Ben Kochie <superq@gmail.com>

Co-authored-by: Ben Kochie <superq@gmail.com>
This commit is contained in:
Miek Gieben
2020-03-26 09:17:33 +01:00
committed by GitHub
parent eb23cce1a7
commit 19cfa2960c
16 changed files with 39 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugin/acl/README.md
View File

@@ -73,8 +73,8 @@ example.org {
If monitoring is enabled (via the _prometheus_ plugin) then the following metrics are exported:
- `coredns_request_block_count_total{server, zone}` - counter of DNS requests being blocked.
- `coredns_dns_blocked_requests_total{server, zone}` - counter of DNS requests being blocked.
- `coredns_request_allow_count_total{server}` - counter of DNS requests being allowed.
- `coredns_dns_allowed_requests_total{server}` - counter of DNS requests being allowed.
The `server` and `zone` labels are explained in the _metrics_ plugin documentation.

4
plugin/acl/metrics.go
View File

@@ -11,14 +11,14 @@ var (
RequestBlockCount = prometheus.NewCounterVec(prometheus.CounterOpts{
Namespace: plugin.Namespace,
Subsystem: "dns",
Name: "request_block_count_total",
Name: "acl_blocked_requests_total",
Help: "Counter of DNS requests being blocked.",
}, []string{"server", "zone"})
// RequestAllowCount is the number of DNS requests being Allowed.
RequestAllowCount = prometheus.NewCounterVec(prometheus.CounterOpts{
Namespace: plugin.Namespace,
Subsystem: "dns",
Name: "request_allow_count_total",
Name: "acl_allowed_requests_total",
Help: "Counter of DNS requests being allowed.",
}, []string{"server"})
)