presubmit: Check errorf as well (#1845)

Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.

plugin/dnssec/black_lies_test.go

@@ -51,11 +51,11 @@ func TestBlackLiesNoError(t *testing.T) {
 	m = d.Sign(state, time.Now().UTC(), server)
 
 	if m.Rcode != dns.RcodeSuccess {
-		t.Errorf("expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
+		t.Errorf("Expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
 	}
 
 	if len(m.Answer) != 2 {
-		t.Errorf("answer section should have 2 RRs")
+		t.Errorf("Answer section should have 2 RRs")
 	}
 	sig, txt := false, false
 	for _, rr := range m.Answer {
@@ -67,7 +67,7 @@ func TestBlackLiesNoError(t *testing.T) {
 		}
 	}
 	if !sig || !txt {
-		t.Errorf("expected RRSIG and TXT in answer section")
+		t.Errorf("Expected RRSIG and TXT in answer section")
 	}
 }
 

plugin/dnssec/handler_test.go

@@ -118,7 +118,7 @@ func TestLookupZone(t *testing.T) {
 		rec := dnstest.NewRecorder(&test.ResponseWriter{})
 		_, err := dh.ServeDNS(ctx, rec, m)
 		if err != nil {
-			t.Errorf("expected no error, got %v\n", err)
+			t.Errorf("Expected no error, got %v\n", err)
 			return
 		}
 
@@ -141,7 +141,7 @@ func TestLookupDNSKEY(t *testing.T) {
 		rec := dnstest.NewRecorder(&test.ResponseWriter{})
 		_, err := dh.ServeDNS(ctx, rec, m)
 		if err != nil {
-			t.Errorf("expected no error, got %v\n", err)
+			t.Errorf("Expected no error, got %v\n", err)
 			return
 		}
 
@@ -157,7 +157,7 @@ func TestLookupDNSKEY(t *testing.T) {
 			if n, ok := rr.(*dns.NSEC); ok {
 				for i := range n.TypeBitMap {
 					if n.TypeBitMap[i] == tc.Qtype {
-						t.Errorf("bitmap contains qtype: %d", tc.Qtype)
+						t.Errorf("Bitmap contains qtype: %d", tc.Qtype)
 					}
 				}
 			}