Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-12-13 22:05:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

presubmit: Check errorf as well (#1845)

Browse Source 
Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.
This commit is contained in:
Miek Gieben
2018-06-02 19:48:39 +01:00
committed by Yong Tang
parent 3994d3a5a7
commit 22c0b30d5f
19 changed files with 57 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugin/dnssec/black_lies_test.go
View File

@@ -51,11 +51,11 @@ func TestBlackLiesNoError(t *testing.T) {
m = d.Sign(state, time.Now().UTC(), server)
if m.Rcode != dns.RcodeSuccess {
t.Errorf("expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
t.Errorf("Expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
}
if len(m.Answer) != 2 {
t.Errorf("answer section should have 2 RRs")
t.Errorf("Answer section should have 2 RRs")
}
sig, txt := false, false
for _, rr := range m.Answer {
@@ -67,7 +67,7 @@ func TestBlackLiesNoError(t *testing.T) {
}
}
if !sig || !txt {
t.Errorf("expected RRSIG and TXT in answer section")
t.Errorf("Expected RRSIG and TXT in answer section")
}
}