Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 00:34:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

core: drop invalid packets (#1123)

Browse Source 
We can still be on the receiving end of invalid packet. Drop them
here.
This commit is contained in:
Miek Gieben
2017-09-29 22:27:40 +01:00
committed by GitHub
parent 2f9c42d82e
commit 23526aec1d
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/dnsserver/server.go
View File

@@ -179,6 +179,13 @@ func (s *Server) Address() string { return s.Addr }
// defined in the request so that the correct zone // defined in the request so that the correct zone
// (configuration and plugin stack) will handle the request. // (configuration and plugin stack) will handle the request.
func (s *Server) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) { func (s *Server) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) {
// our dns library protects us against really invalid packets, we can still
// get semi valid packets. Drop them here.
if r == nil || len(r.Question) == 0 {
DefaultErrorFunc(w, r, dns.RcodeServerFailure)
return
}
if !s.debug { if !s.debug {
defer func() { defer func() {
// In case the user doesn't enable error plugin, we still // In case the user doesn't enable error plugin, we still