From 24e668ecf085597faa3100f130a85c480a36c7cb Mon Sep 17 00:00:00 2001
From: Miek Gieben <miek@miek.nl>
Date: Tue, 22 Sep 2020 09:22:00 +0200
Subject: [PATCH] goreport card fixes (#4139)

This fixes some inefassign as report by Go report card:
https://goreportcard.com/report/github.com/coredns/coredns

Signed-off-by: Miek Gieben <miek@miek.nl>
---
 plugin/kubernetes/informer_test.go | 4 ++--
 plugin/test/helpers.go             | 2 +-
 plugin/transfer/transfer.go        | 1 -
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/plugin/kubernetes/informer_test.go b/plugin/kubernetes/informer_test.go
index d47d6feee..5156554e9 100644
--- a/plugin/kubernetes/informer_test.go
+++ b/plugin/kubernetes/informer_test.go
@@ -83,7 +83,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
 	if err != nil {
 		t.Fatalf("delete test failed: %v", err)
 	}
-	got, exists, err = idx.Get(obj2)
+	_, exists, err = idx.Get(obj2)
 	if err != nil {
 		t.Fatalf("get deleted object failed: %v", err)
 	}
@@ -101,7 +101,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
 	if err != nil {
 		t.Fatalf("tombstone delete test failed: %v", err)
 	}
-	got, exists, err = idx.Get(svc)
+	_, exists, err = idx.Get(svc)
 	if err != nil {
 		t.Fatalf("get tombstone deleted object failed: %v", err)
 	}
diff --git a/plugin/test/helpers.go b/plugin/test/helpers.go
index 21fb277c0..fa89f9218 100644
--- a/plugin/test/helpers.go
+++ b/plugin/test/helpers.go
@@ -248,7 +248,7 @@ func Section(tc Case, sec sect, rr []dns.RR) error {
 	return nil
 }
 
-// CNAMEOrder makes sure that CNAMES do not appear after their target records
+// CNAMEOrder makes sure that CNAMES do not appear after their target records.
 func CNAMEOrder(res *dns.Msg) error {
 	for i, c := range res.Answer {
 		if c.Header().Rrtype != dns.TypeCNAME {
diff --git a/plugin/transfer/transfer.go b/plugin/transfer/transfer.go
index 0bf92ac47..1112ffb9e 100644
--- a/plugin/transfer/transfer.go
+++ b/plugin/transfer/transfer.go
@@ -140,7 +140,6 @@ receive:
 	if len(rrs) > 0 {
 		ch <- &dns.Envelope{RR: rrs}
 		l += len(rrs)
-		rrs = []dns.RR{}
 	}
 
 	if soa != nil {