Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 00:04:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

GO linting bump and removal of deprecated linters (#5624)

Browse Source 
* bump golangci-lint with support of go 1.19

Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>

* remove deprecated usage of varcheck, deadcode, and structcheck

Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>

Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
This commit is contained in:
Ondřej Benkovský
2022-09-19 14:53:43 +02:00
committed by GitHub
parent 596a9f9e67
commit 257ca65a17
4 changed files with 7 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/presubmit_test.go
View File

@@ -125,7 +125,7 @@ func (l logfmt) Visit(n ast.Node) ast.Visitor {
if !ok {
return l
}
if id.Name != "t" { //t *testing.T
if id.Name != "t" { // t *testing.T
return l
}
@@ -182,41 +182,6 @@ func TestImportTesting(t *testing.T) {
}
}
type hasImportTestingWalker struct {
Errors []error
}
func (w *hasImportTestingWalker) walk(path string, info os.FileInfo, _ error) error {
// only for regular files, not starting with a . and those that are go files.
if !info.Mode().IsRegular() {
return nil
}
if strings.HasPrefix(path, "../.") {
return nil
}
if strings.Contains(path, "/vendor") {
return nil
}
if strings.HasSuffix(path, "_test.go") {
return nil
}
if strings.HasSuffix(path, ".go") {
fs := token.NewFileSet()
f, err := parser.ParseFile(fs, path, nil, parser.AllErrors)
if err != nil {
return err
}
for _, im := range f.Imports {
if im.Path.Value == `"testing"` {
absPath, _ := filepath.Abs(path)
w.Errors = append(w.Errors, fmt.Errorf("file %q is importing %q", absPath, "testing"))
}
}
}
return nil
}
func TestImportOrdering(t *testing.T) {
walker := testImportOrderingWalker{}
err := filepath.Walk("..", walker.walk)