Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-01 02:33:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use dns.IsSubDomain (#112)

Browse Source 
For the match function use the proper thing from go dns. Fix all
callers and tests to use this.

Fixes: #107
This commit is contained in:
Miek Gieben
2016-04-12 22:34:44 +01:00
parent 842953f179
commit 25cf16af0e
8 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
middleware/proxy/upstream.go
View File

@@ -238,6 +238,9 @@ func (u *staticUpstream) Select() *UpstreamHost {
func (u *staticUpstream) IsAllowedPath(name string) bool {
for _, ignoredSubDomain := range u.IgnoredSubDomains {
if dns.Name(name) == dns.Name(u.From()) {
return true
}
if middleware.Name(name).Matches(ignoredSubDomain + u.From()) {
return false
}

2
middleware/proxy/upstream_test.go
View File

@@ -70,7 +70,7 @@ func TestAllowedPaths(t *testing.T) {
for i, test := range tests {
isAllowed := upstream.IsAllowedPath(test.name)
if test.expected != isAllowed {
t.Errorf("Test %d: expected %v found %v", i+1, test.expected, isAllowed)
t.Errorf("Test %d: expected %v found %v for %s", i+1, test.expected, isAllowed, test.name)
}
}
}