plugin/ready: Reset list of readiness plugins on startup (#5492)

* reset readiness plugins list on startup

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

plugin/ready/list.go

@@ -13,6 +13,14 @@ type list struct {
 	names []string
 }
 
+// Reset resets l
+func (l *list) Reset() {
+	l.Lock()
+	defer l.Unlock()
+	l.rs = nil
+	l.names = nil
+}
+
 // Append adds a new readiness to l.
 func (l *list) Append(r Readiness, name string) {
 	l.Lock()

plugin/ready/setup.go

@@ -25,6 +25,7 @@ func setup(c *caddy.Controller) error {
 	c.OnRestartFailed(func() error { return uniqAddr.ForEach() })
 
 	c.OnStartup(func() error {
+		plugins.Reset()
 		for _, p := range dnsserver.GetConfig(c).Handlers() {
 			if r, ok := p.(Readiness); ok {
 				plugins.Append(r, p.Name())