From 2caddcf76192e0266dc5b699be29f595ad2477c1 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Thu, 24 Mar 2016 17:51:28 +0000 Subject: [PATCH] Small optimization in round robin load balancing --- middleware/loadbalance/loadbalance.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/middleware/loadbalance/loadbalance.go b/middleware/loadbalance/loadbalance.go index 5d96beaba..c81ad0c8a 100644 --- a/middleware/loadbalance/loadbalance.go +++ b/middleware/loadbalance/loadbalance.go @@ -14,7 +14,7 @@ func (r *RoundRobinResponseWriter) WriteMsg(res *dns.Msg) error { if res.Rcode != dns.RcodeSuccess { return r.ResponseWriter.WriteMsg(res) } - if len(res.Answer) == 1 { + if len(res.Answer) < 2 { // don't even bother return r.ResponseWriter.WriteMsg(res) } @@ -56,8 +56,8 @@ func (r *RoundRobinResponseWriter) WriteMsg(res *dns.Msg) error { return r.ResponseWriter.WriteMsg(res) } +// Should we pack and unpack here to fiddle with the packet... Not likely. func (r *RoundRobinResponseWriter) Write(buf []byte) (int, error) { - // pack and unpack? Not likely n, err := r.ResponseWriter.Write(buf) return n, err }