From 2fe42067fad983f8b6b35a4df779814bdeaa7bb8 Mon Sep 17 00:00:00 2001
From: Miek Gieben <miek@miek.nl>
Date: Tue, 14 Jun 2016 18:04:29 +0100
Subject: [PATCH] Spray to backend hosts when all are unhealthy (#171)

When all backend hosts are unhealthy, randomly select one and use
that as a target.

This is to preempt the health checking itself failing.
---
 middleware/proxy/README.md |  3 +++
 middleware/proxy/policy.go | 23 +++++++++++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/middleware/proxy/README.md b/middleware/proxy/README.md
index 40f83caa4..d1ffaaf6d 100644
--- a/middleware/proxy/README.md
+++ b/middleware/proxy/README.md
@@ -45,6 +45,9 @@ There are three load balancing policies available:
 * *least_conn* - Select backend with the fewest active connections
 * *round_robin* - Select backend in round-robin fashion
 
+All polices implement randomly spraying packets to backend hosts when *no healthy* hosts are
+available. This is to preeempt the case where the healthchecking (as a mechanism) fails.
+
 ## Examples
 
 Proxy all requests within example.org. to a backend system:
diff --git a/middleware/proxy/policy.go b/middleware/proxy/policy.go
index a2522bcb1..077ecff33 100644
--- a/middleware/proxy/policy.go
+++ b/middleware/proxy/policy.go
@@ -8,7 +8,9 @@ import (
 // HostPool is a collection of UpstreamHosts.
 type HostPool []*UpstreamHost
 
-// Policy decides how a host will be selected from a pool.
+// Policy decides how a host will be selected from a pool. When all hosts are unhealthy, it is assumed the
+// healthchecking failed. In this case each policy will *randomly* return a host from the pool to prevent
+// no traffic to go through at all.
 type Policy interface {
 	Select(pool HostPool) *UpstreamHost
 }
@@ -42,6 +44,20 @@ func (r *Random) Select(pool HostPool) *UpstreamHost {
 			}
 		}
 	}
+	if randHost == nil {
+		return new(Spray).Select(pool)
+	}
+	return randHost
+}
+
+// Spray is a policy that selects a host from a pool at random. This should be used as a last ditch
+// attempt to get a host when all hosts are reporting unhealthy.
+type Spray struct{}
+
+// Select selects an up host at random from the specified pool.
+func (r *Spray) Select(pool HostPool) *UpstreamHost {
+	rnd := rand.Int() % len(pool)
+	randHost := pool[rnd]
 	return randHost
 }
 
@@ -77,6 +93,9 @@ func (r *LeastConn) Select(pool HostPool) *UpstreamHost {
 			}
 		}
 	}
+	if bestHost == nil {
+		return new(Spray).Select(pool)
+	}
 	return bestHost
 }
 
@@ -95,7 +114,7 @@ func (r *RoundRobin) Select(pool HostPool) *UpstreamHost {
 		host = pool[(selection+i)%poolLen]
 	}
 	if host.Down() {
-		return nil
+		return new(Spray).Select(pool)
 	}
 	return host
 }