Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-29 17:24:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix typos (#6235)

Browse Source 
* Fix typos and add todo to fix spelling of dnsutil.MaximumDefaulTTL

Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com>
This commit is contained in:
Zhizhen He
2023-08-10 23:06:48 +08:00
committed by GitHub
parent c657af467b
commit 2fe5890d8b
13 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
plugin/pkg/dnsutil/ttl.go
View File

@@ -48,5 +48,6 @@ const (
// MinimalDefaultTTL is the absolute lowest TTL we use in CoreDNS.
MinimalDefaultTTL = 5 * time.Second
// MaximumDefaulTTL is the maximum TTL was use on RRsets in CoreDNS.
// TODO: rename as MaximumDefaultTTL
MaximumDefaulTTL = 1 * time.Hour
)

4
plugin/pkg/log/listener_test.go
View File

@@ -11,7 +11,7 @@ func TestRegisterAndDeregisterListener(t *testing.T) {
for _, name := range []string{"listener1", "listener2", "listener1"} {
err := RegisterListener(NewMockListener(name))
if err != nil {
t.Errorf("RegsiterListener Error %s", err)
t.Errorf("RegisterListener Error %s", err)
}
}
if len(ls.listeners) != 2 {
@@ -46,7 +46,7 @@ func testListenersCalled(t *testing.T, listenerNames []string, outputs []string)
for _, name := range listenerNames {
err := RegisterListener(NewMockListener(name))
if err != nil {
t.Errorf("RegsiterListener Error %s", err)
t.Errorf("RegisterListener Error %s", err)
}
}
var f bytes.Buffer

6
plugin/pkg/up/up.go
View File

@@ -10,9 +10,9 @@ import (
// Probe is used to run a single Func until it returns true (indicating a target is healthy). If an Func
// is already in progress no new one will be added, i.e. there is always a maximum of 1 checks in flight.
//
// There is a tradeoff to be made in figuring out quickly that an upstream is healthy and not doing to much work
// (sending queries) to find that out. Having some kind of exp. backoff here won't help much, because you don't won't
// to backoff too much. You then also need random queries to be perfomed every so often to quickly detect a working
// There is a tradeoff to be made in figuring out quickly that an upstream is healthy and not doing much work
// (sending queries) to find that out. Having some kind of exp. backoff here won't help much, because you don't want
// to backoff too much. You then also need random queries to be performed every so often to quickly detect a working
// upstream. In the end we just send a query every 0.5 second to check the upstream. This hopefully strikes a balance
// between getting information about the upstream state quickly and not doing too much work. Note that 0.5s is still an
// eternity in DNS, so we may actually want to shorten it.