Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 00:34:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use cancelable contexts for cloud provider plugin refreshes (#4226)

Browse Source 
This commit uses a cancelable context to spawn goroutines that refresh
records from a cloud DNS provider. The Caddy shutdown routine uses the
returned cancel function to terminate existing goroutines when a USR1
reload signal is received.

Signed-off-by: Matt Kulka <mkulka@parchment.com>
This commit is contained in:
Matt Kulka
2020-10-24 05:37:01 -07:00
committed by GitHub
parent 054c9ae1fb
commit 3168a722ca
6 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugin/azure/setup.go
View File

@@ -25,7 +25,7 @@ func setup(c *caddy.Controller) error {
if err != nil {
return plugin.Error("azure", err)
}
ctx := context.Background()
ctx, cancel := context.WithCancel(context.Background())
publicDNSClient := publicAzureDNS.NewRecordSetsClient(env.Values[auth.SubscriptionID])
if publicDNSClient.Authorizer, err = env.GetAuthorizer(); err != nil {
@@ -50,6 +50,7 @@ func setup(c *caddy.Controller) error {
h.Next = next
return h
})
c.OnShutdown(func() error { cancel(); return nil })
return nil
}