From 37d06f382a71f449e9f10eff219d2e2e2036cc98 Mon Sep 17 00:00:00 2001 From: John Belamaric Date: Fri, 29 Sep 2017 17:28:37 -0400 Subject: [PATCH] Warn if the hosts file is a directory (#1126) --- plugin/hosts/setup.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugin/hosts/setup.go b/plugin/hosts/setup.go index 0c13140bb..48beb0dcb 100644 --- a/plugin/hosts/setup.go +++ b/plugin/hosts/setup.go @@ -50,7 +50,7 @@ func hostsParse(c *caddy.Controller) (Hosts, error) { if !path.IsAbs(h.path) && config.Root != "" { h.path = path.Join(config.Root, h.path) } - _, err := os.Stat(h.path) + s, err := os.Stat(h.path) if err != nil { if os.IsNotExist(err) { log.Printf("[WARNING] File does not exist: %s", h.path) @@ -58,6 +58,9 @@ func hostsParse(c *caddy.Controller) (Hosts, error) { return h, c.Errf("unable to access hosts file '%s': %v", h.path, err) } } + if s != nil && s.IsDir() { + log.Printf("[WARNING] hosts file %q is a directory", h.path) + } } origins := make([]string, len(c.ServerBlockKeys))