From 440e92465d8e509076e060bc9f810f132af425de Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sun, 25 Sep 2016 19:19:15 +0100 Subject: [PATCH] Rename port to dns.port (#300) Avoid clashing with other server types. --- core/dnsserver/register.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/dnsserver/register.go b/core/dnsserver/register.go index b84ff8595..224ba71e9 100644 --- a/core/dnsserver/register.go +++ b/core/dnsserver/register.go @@ -14,8 +14,10 @@ import ( const serverType = "dns" +// Any flags defined here, need to be namespaced to the serverType other +// wise they potentially clash with other server types. func init() { - flag.StringVar(&Port, "port", DefaultPort, "Default port") + flag.StringVar(&Port, serverType+".port", DefaultPort, "Default port") caddy.RegisterServerType(serverType, caddy.ServerType{ Directives: func() []string { return directives },