Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-03 18:53:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Revert "be sure to close connection after completion of xfr out. (#2866)" (#2872)

Browse Source 
This reverts commit a657e1f661.
This commit is contained in:
Miek Gieben
2019-06-07 15:29:42 +01:00
committed by GitHub
parent a657e1f661
commit 458e778113
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugin/file/xfr.go
View File

@@ -33,10 +33,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
ch := make(chan *dns.Envelope) ch := make(chan *dns.Envelope)
defer close(ch) defer close(ch)
tr := new(dns.Transfer) tr := new(dns.Transfer)
go func() { go tr.Out(w, r, ch)
tr.Out(w, r, ch)
w.Close()
}()
j, l := 0, 0 j, l := 0, 0
records = append(records, records[0]) // add closing SOA to the end records = append(records, records[0]) // add closing SOA to the end
@@ -54,6 +51,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
} }
w.Hijack() w.Hijack()
// w.Close() // Client closes connection
return dns.RcodeSuccess, nil return dns.RcodeSuccess, nil
} }