mirror of
https://github.com/coredns/coredns.git
synced 2026-04-05 11:45:33 -04:00
plugin/tsig: add require_opcode directive for opcode-based TSIG (#7828)
Extend the tsig plugin to require TSIG signatures based on DNS opcodes,
similar to the existing qtype-based requirement.
The new require_opcode directive accepts opcode names (QUERY, IQUERY,
STATUS, NOTIFY, UPDATE) or the special values "all" and "none".
This is useful for requiring TSIG on dynamic update (UPDATE) or zone
transfer notification (NOTIFY) requests while allowing unsigned queries.
Example:
```
tsig {
secret key. NoTCJU+DMqFWywaPyxSijrDEA/eC3nK0xi3AMEZuPVk=
require_opcode UPDATE NOTIFY
}
```
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
This commit is contained in:
@@ -43,6 +43,7 @@ func parse(c *caddy.Controller) (*TSIGServer, error) {
|
||||
t := &TSIGServer{
|
||||
secrets: make(map[string]string),
|
||||
types: defaultQTypes,
|
||||
opcodes: defaultOpCodes,
|
||||
}
|
||||
|
||||
for i := 0; c.Next(); i++ {
|
||||
@@ -89,7 +90,7 @@ func parse(c *caddy.Controller) (*TSIGServer, error) {
|
||||
return nil, c.ArgErr()
|
||||
}
|
||||
if args[0] == "all" {
|
||||
t.all = true
|
||||
t.allTypes = true
|
||||
continue
|
||||
}
|
||||
if args[0] == "none" {
|
||||
@@ -102,6 +103,26 @@ func parse(c *caddy.Controller) (*TSIGServer, error) {
|
||||
}
|
||||
t.types[qt] = struct{}{}
|
||||
}
|
||||
case "require_opcode":
|
||||
t.opcodes = opCodes{}
|
||||
args := c.RemainingArgs()
|
||||
if len(args) == 0 {
|
||||
return nil, c.ArgErr()
|
||||
}
|
||||
if args[0] == "all" {
|
||||
t.allOpcodes = true
|
||||
continue
|
||||
}
|
||||
if args[0] == "none" {
|
||||
continue
|
||||
}
|
||||
for _, str := range args {
|
||||
op, ok := dns.StringToOpcode[str]
|
||||
if !ok {
|
||||
return nil, c.Errf("unknown opcode '%s'", str)
|
||||
}
|
||||
t.opcodes[op] = struct{}{}
|
||||
}
|
||||
default:
|
||||
return nil, c.Errf("unknown property '%s'", c.Val())
|
||||
}
|
||||
@@ -166,3 +187,4 @@ func parseKeyFile(f io.Reader) (map[string]string, error) {
|
||||
}
|
||||
|
||||
var defaultQTypes = qTypes{}
|
||||
var defaultOpCodes = opCodes{}
|
||||
|
||||
Reference in New Issue
Block a user