From 486ceaddd877af22466c8ebefca59403705dc365 Mon Sep 17 00:00:00 2001 From: ump45nose <52391318+ump45nose@users.noreply.github.com> Date: Sun, 18 Oct 2026 15:04:03 +0800 Subject: [PATCH] plugin/metrics: drop the nonexistent type label from request_duration_seconds (#8650) The RequestDuration histogram is declared with labels server, zone and view only (plugin/metrics/vars/vars.go) and report.go observes it with those three values. The type label belongs to requests_total, not to the duration histogram, so remove it from the README metric list. Signed-off-by: yuwk <1729065730@qq.com> --- plugin/metrics/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/metrics/README.md b/plugin/metrics/README.md index dc57c3bac..d8b24c9e8 100644 --- a/plugin/metrics/README.md +++ b/plugin/metrics/README.md @@ -15,7 +15,7 @@ the following metrics are exported: * `coredns_build_info{version, revision, goversion}` - info about CoreDNS itself. * `coredns_panics_total{}` - total number of panics. * `coredns_dns_requests_total{server, zone, view, proto, family, type}` - total query count. -* `coredns_dns_request_duration_seconds{server, zone, view, type}` - duration to process each query. +* `coredns_dns_request_duration_seconds{server, zone, view}` - duration to process each query. * `coredns_dns_request_size_bytes{server, zone, view, proto}` - size of the request in bytes. Uses the original size before any plugin rewrites. * `coredns_dns_do_requests_total{server, view, zone}` - queries that have the DO bit set * `coredns_dns_response_size_bytes{server, zone, view, proto}` - response size in bytes.