Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

release: speed up build (#1181)

Browse Source 
Don't use the 'check and godep' target when building for a release, this
is now repeated 6 times for no reason as this is already checked on
travis.

Some other cleanups in the documentation as well.
This commit is contained in:
Miek Gieben
2017-10-30 15:55:41 +00:00
committed by Yong Tang
parent 22f9fc5aa5
commit 4a4556f0d6
2 changed files with 28 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile
View File

@@ -1,13 +1,13 @@
# Makefile for building CoreDNS
GITCOMMIT:=$(shell git describe --dirty --always) GITCOMMIT:=$(shell git describe --dirty --always)
BINARY:=coredns BINARY:=coredns
SYSTEM:= SYSTEM:=
CHECKS:=check godeps
all: coredns all: coredns
# Phony this to ensure we always build the binary.
# TODO: Add .go file dependencies.
.PHONY: coredns .PHONY: coredns
coredns: check godeps coredns: $(CHECKS)
CGO_ENABLED=0 $(SYSTEM) go build -v -ldflags="-s -w -X github.com/coredns/coredns/coremain.gitCommit=$(GITCOMMIT)" -o $(BINARY) CGO_ENABLED=0 $(SYSTEM) go build -v -ldflags="-s -w -X github.com/coredns/coredns/coremain.gitCommit=$(GITCOMMIT)" -o $(BINARY)
.PHONY: check .PHONY: check

54
Makefile.release
View File

@@ -1,43 +1,38 @@
# Makefile for releasing CoreDNS # Makefile for releasing CoreDNS
# #
# The release binaries are built through docker run like # The release is controlled from coremain/version.go. The version found there is
# make coredns # used to tag the git repo and to build the assets that are uploaded to github
# (after some sanity checks).
# #
# There advantage of the above command is that we could control reused # The release should be accompanied by release notes published on coredns.io.
# the binary generation from the default `Makefile`, instread of repeating # For example: https://coredns.io/2016/09/18/coredns-001-release/ Also send an
# in `Makefile.release`. # email to coredns-discuss@ to announce the new version.
# #
# The release is controlled from coremain/version.go. The version found # We use https://github.com/progrium/gh-release to automate github stuff be sure
# there is used to tag the git repo and to build the assets that are # to have that binary in your path.
# uploaded to github (after some sanity checks).
#
# The release should be accompanied by release notes published on
# coredns.io. For example:
# https://coredns.io/2016/09/18/coredns-001-release/
# Also send an email to coredns-discuss@ to announce the new version.
#
# We use https://github.com/progrium/gh-release to automate github stuff
# be sure to have that binary in your path.
# #
# Get a list of authors for this release with: # Get a list of authors for this release with:
# #
# git log --pretty=format:'%an' v001..master | sort -u # git log --pretty=format:'%an' v001..master | sort -u (where v001 is the
# (where v001 is the previous release, obviously you'll need to adjust this) # previous release, obviously you'll need to adjust this)
# #
# Steps: # Steps:
#
# * Get an access token: https://help.github.com/articles/creating-an-access-token-for-command-line-use/ # * Get an access token: https://help.github.com/articles/creating-an-access-token-for-command-line-use/
# * export GITHUB_ACCESS_TOKEN=<token> # * export GITHUB_ACCESS_TOKEN=<token>
# * Up the version in coremain/version.go # * Up the version in coremain/version.go
# * Run: make -f Makefile.release release # * Run: make -f Makefile.release release
# * will commit your change with 'Release $VERSION' # * will *commit* your change with 'Release $VERSION'
# * push to github # * push to github
# * build the release and do all that fluff. # * build the release and do all that fluff.
# #
# Steps for docker # Steps for docker:
#
# * Login into docker: docker login (should have push creds for coredns registry) # * Login into docker: docker login (should have push creds for coredns registry)
# * Run: make -f Makefile.release docker # * Run: make -f Makefile.release docker
# #
# Docker push should happen after you make the new release and uploaded it to Github. # Docker push should happen after you make the new release and uploaded it to
# Github.
ifeq (, $(shell which gh-release)) ifeq (, $(shell which gh-release))
$(error "No gh-release in $$PATH, install with `go get progrium/gh-release`") $(error "No gh-release in $$PATH, install with `go get progrium/gh-release`")
@@ -71,22 +66,23 @@ commit:
.PHONY: build .PHONY: build
build: build:
@echo Cleaning old builds @echo Cleaning old builds
rm -rf build rm -rf build && mkdir build
@echo Building: linux $(VERSION) @echo Building: linux $(VERSION)
mkdir -p build/linux/$(ARCH) && $(MAKE) coredns BINARY=build/linux/$(ARCH)/$(NAME) SYSTEM="GOOS=linux" mkdir -p build/linux/$(ARCH) && $(MAKE) coredns BINARY=build/linux/$(ARCH)/$(NAME) SYSTEM="GOOS=linux" CHECKS=""
@echo Building: darwin $(VERSION) @echo Building: darwin $(VERSION)
mkdir -p build/darwin/$(ARCH) && $(MAKE) coredns BINARY=build/darwin/$(ARCH)/$(NAME) SYSTEM="GOOS=darwin" mkdir -p build/darwin/$(ARCH) && $(MAKE) coredns BINARY=build/darwin/$(ARCH)/$(NAME) SYSTEM="GOOS=darwin" CHECKS=""
@echo Building: arm $(VERSION) @echo Building: arm $(VERSION)
mkdir -p build/linux/arm && $(MAKE) coredns BINARY=build/linux/arm/$(NAME) SYSTEM="GOOS=linux GOARCH=arm" mkdir -p build/linux/arm && $(MAKE) coredns BINARY=build/linux/arm/$(NAME) SYSTEM="GOOS=linux GOARCH=arm" CHECKS=""
@echo Building: arm64 $(VERSION) @echo Building: arm64 $(VERSION)
mkdir -p build/linux/arm64 && $(MAKE) coredns BINARY=build/linux/arm64/$(NAME) SYSTEM="GOOS=linux GOARCH=arm64" mkdir -p build/linux/arm64 && $(MAKE) coredns BINARY=build/linux/arm64/$(NAME) SYSTEM="GOOS=linux GOARCH=arm64" CHECKS=""
@echo Building: ppc64 $(VERSION) @echo Building: ppc64 $(VERSION)
mkdir -p build/linux/ppc64 && $(MAKE) coredns BINARY=build/linux/ppc64/$(NAME) SYSTEM="GOOS=linux GOARCH=ppc64le" mkdir -p build/linux/ppc64 && $(MAKE) coredns BINARY=build/linux/ppc64/$(NAME) SYSTEM="GOOS=linux GOARCH=ppc64le" CHECKS=""
@echo Building: s390x $(VERSION) @echo Building: s390x $(VERSION)
mkdir -p build/linux/s390 && $(MAKE) coredns BINARY=build/linux/s390/$(NAME) SYSTEM="GOOS=linux GOARCH=s390x" mkdir -p build/linux/s390 && $(MAKE) coredns BINARY=build/linux/s390/$(NAME) SYSTEM="GOOS=linux GOARCH=s390x" CHECKS=""
.PHONY: tar .PHONY: tar
tar: tar:
@echo Cleaning old releases
rm -rf release && mkdir release rm -rf release && mkdir release
tar -zcf release/$(NAME)_$(VERSION)_linux_$(ARCH).tgz -C build/linux/$(ARCH) $(NAME) tar -zcf release/$(NAME)_$(VERSION)_linux_$(ARCH).tgz -C build/linux/$(ARCH) $(NAME)
tar -zcf release/$(NAME)_$(VERSION)_darwin_$(ARCH).tgz -C build/darwin/$(ARCH) $(NAME) tar -zcf release/$(NAME)_$(VERSION)_darwin_$(ARCH).tgz -C build/darwin/$(ARCH) $(NAME)