Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-04-07 20:45:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(kubernetes): sanitize non-UTF-8 host in metrics (#7998)

Browse Source
This commit is contained in:
Ville Vesilehto
2026-04-02 00:19:29 +03:00
committed by GitHub
parent 529320db4b
commit 503c2d7ea3
3 changed files with 56 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugin/kubernetes/metrics.go
View File

@@ -3,7 +3,9 @@ package kubernetes
import (
"context"
"net/url"
"strings"
"time"
"unicode/utf8"
"github.com/coredns/coredns/plugin"
@@ -64,7 +66,7 @@ type latencyAdapter struct {
}
func (l *latencyAdapter) Observe(_ context.Context, verb string, u url.URL, latency time.Duration) {
l.m.WithLabelValues(verb, u.Host).Observe(latency.Seconds())
l.m.WithLabelValues(verb, sanitizeLabelValue(u.Host)).Observe(latency.Seconds())
}
type resultAdapter struct {
@@ -72,5 +74,14 @@ type resultAdapter struct {
}
func (r *resultAdapter) Increment(_ context.Context, code, method, host string) {
r.m.WithLabelValues(code, method, host).Inc()
r.m.WithLabelValues(code, method, sanitizeLabelValue(host)).Inc()
}
// sanitizeLabelValue ensures the string is valid UTF-8, which is required by
// Prometheus for label values. Invalid bytes are replaced with U+FFFD.
func sanitizeLabelValue(s string) string {
if utf8.ValidString(s) {
return s
}
return strings.ToValidUTF8(s, "\uFFFD")
}