Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-12-10 20:35:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Run golint and go vet (#276)

Browse Source 
Cleanup the errors and removed deadcode along the way. The leaves
some error laying around, mostly about commenting exported identifier.
We should look hard if those really are needed.
This commit is contained in:
Miek Gieben
2016-09-21 17:01:19 +01:00
committed by GitHub
parent 7b79458c8a
commit 5301c5af5f
25 changed files with 60 additions and 386 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
request/request.go
View File

@@ -40,7 +40,7 @@ func (r *Request) IP() string {
return ip
}
// Post gets the (remote) Port of the client making the request.
// Port gets the (remote) Port of the client making the request.
func (r *Request) Port() string {
_, port, err := net.SplitHostPort(r.W.RemoteAddr().String())
if err != nil {
@@ -57,9 +57,9 @@ func (r *Request) RemoteAddr() string {
// Proto gets the protocol used as the transport. This will be udp or tcp.
func (r *Request) Proto() string { return Proto(r.W) }
// FIXME(miek): why not a method on Request
// Proto gets the protocol used as the transport. This will be udp or tcp.
func Proto(w dns.ResponseWriter) string {
// FIXME(miek): why not a method on Request
if _, ok := w.RemoteAddr().(*net.UDPAddr); ok {
return "udp"
}