From 5fb9804713c99f6900923584d87f4307c6686327 Mon Sep 17 00:00:00 2001 From: Shiv Tyagi <67995771+shiv-tyagi@users.noreply.github.com> Date: Mon, 12 Jan 2026 22:21:45 +0530 Subject: [PATCH] chore: allow to override -ldflags via ENV VAR for make coredns target (#7807) --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8ee633c36..b95f8cc7e 100644 --- a/Makefile +++ b/Makefile @@ -8,6 +8,8 @@ GOPATH?=$(HOME)/go MAKEPWD:=$(dir $(realpath $(firstword $(MAKEFILE_LIST)))) CGO_ENABLED?=0 GOLANG_VERSION ?= $(shell cat .go-version) +STRIP_FLAGS?=-s -w +LDFLAGS?=-ldflags="$(STRIP_FLAGS) -X github.com/coredns/coredns/coremain.GitCommit=$(GITCOMMIT)" export GOSUMDB = sum.golang.org export GOTOOLCHAIN = go$(GOLANG_VERSION) @@ -17,7 +19,7 @@ all: coredns .PHONY: coredns coredns: $(CHECKS) - CGO_ENABLED=$(CGO_ENABLED) $(SYSTEM) go build $(BUILDOPTS) -ldflags="-s -w -X github.com/coredns/coredns/coremain.GitCommit=$(GITCOMMIT)" -o $(BINARY) + CGO_ENABLED=$(CGO_ENABLED) $(SYSTEM) go build $(BUILDOPTS) $(LDFLAGS) -o $(BINARY) .PHONY: check check: core/plugin/zplugin.go core/dnsserver/zdirectives.go