plugin/bind: Bind by interface name (#4522)

* auto make -f Makefile.doc

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* Bind by interface name

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* README.md: Interface with multiple address

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* auto make -f Makefile.doc

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* auto make -f Makefile.doc

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* Elaborate more on the behaviour in README.md, revert man/*, fix tests

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* auto make -f Makefile.doc

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* --sign-off

Revert man/* to fix DCO check

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

* auto make -f Makefile.doc

* Revert man/* to fix DCO check

Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>

Co-authored-by: coredns-auto-go-mod-tidy[bot] <coredns-auto-go-mod-tidy[bot]@users.noreply.github.com>
This commit is contained in:
Mohammad Yosefpor
2021-03-18 10:08:48 +03:30
committed by GitHub
parent 5457cdcd4b
commit 61b5cdb352
3 changed files with 43 additions and 8 deletions

View File

@@ -15,16 +15,40 @@ func setup(c *caddy.Controller) error {
// addresses will be consolidated over all BIND directives available in that BlocServer
all := []string{}
for c.Next() {
addrs := c.RemainingArgs()
if len(addrs) == 0 {
return plugin.Error("bind", fmt.Errorf("at least one address is expected"))
args := c.RemainingArgs()
if len(args) == 0 {
return plugin.Error("bind", fmt.Errorf("at least one address or interface name is expected"))
}
for _, addr := range addrs {
if net.ParseIP(addr) == nil {
return plugin.Error("bind", fmt.Errorf("not a valid IP address: %s", addr))
ifaces, err := net.Interfaces()
if err != nil {
return plugin.Error("bind", fmt.Errorf("failed to get interfaces list"))
}
var isIface bool
for _, arg := range args {
isIface = false
for _, iface := range ifaces {
if arg == iface.Name {
isIface = true
addrs, err := iface.Addrs()
if err != nil {
return plugin.Error("bind", fmt.Errorf("failed to get the IP(s) of the interface: %s", arg))
}
for _, addr := range addrs {
if ipnet, ok := addr.(*net.IPNet); ok {
all = append(all, ipnet.IP.String())
}
}
}
}
if !isIface {
if net.ParseIP(arg) == nil {
return plugin.Error("bind", fmt.Errorf("not a valid IP address: %s", arg))
}
all = append(all, arg)
}
}
all = append(all, addrs...)
}
config.ListenHosts = all
return nil