perf: avoid string concatenation in loops (#7572)

* perf: avoid string concatenation in loops

Apply perfpsrint linter

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>

* ci: enable perfsprint

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>

---------

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>
This commit is contained in:
Catena cyber
2025-10-06 09:05:58 +02:00
committed by GitHub
parent 51f94b0bb4
commit 625f6c9307
8 changed files with 36 additions and 24 deletions

View File

@@ -1,5 +1,9 @@
package auto
import (
"strings"
)
// rewriteToExpand rewrites our template string to one that we can give to regexp.ExpandString. This basically
// involves prefixing any '{' with a '$'.
func rewriteToExpand(s string) string {
@@ -7,14 +11,13 @@ func rewriteToExpand(s string) string {
// Also wasteful as we build the string with +=. This is OKish
// as we do this during config parsing.
copy := ""
var copySb strings.Builder
for _, c := range s {
if c == '{' {
copy += "$"
copySb.WriteString("$")
}
copy += string(c)
copySb.WriteString(string(c))
}
return copy
return copySb.String()
}