Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid string concatenation in loops (#7572)

Browse Source 
* perf: avoid string concatenation in loops

Apply perfpsrint linter

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>

* ci: enable perfsprint

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>

---------

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>
This commit is contained in:
Catena cyber
2025-10-06 09:05:58 +02:00
committed by GitHub
parent 51f94b0bb4
commit 625f6c9307
8 changed files with 36 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugin/route53/route53.go
View File

@@ -171,14 +171,14 @@ const escapeSeq = "\\"
// `\\052.example.com.` -> `*.example.com`
// `\\137.example.com.` -> error ('_' is not valid)
func maybeUnescape(s string) (string, error) {
var out string
var outSb strings.Builder
for {
i := strings.Index(s, escapeSeq)
if i < 0 {
return out + s, nil
return outSb.String() + s, nil
}
out += s[:i]
outSb.WriteString(s[:i])
li, ri := i+len(escapeSeq), i+len(escapeSeq)+3
if ri > len(s) {
@@ -196,7 +196,7 @@ func maybeUnescape(s string) (string, error) {
case r >= rune('a') && r <= rune('z'): // Route53 converts everything to lowercase.
case r >= rune('0') && r <= rune('9'):
case r == rune('*'):
if out != "" {
if outSb.Len() != 0 {
return "", errors.New("`*' only supported as wildcard (leftmost label)")
}
case r == rune('-'):
@@ -205,7 +205,7 @@ func maybeUnescape(s string) (string, error) {
return "", fmt.Errorf("invalid character: %s%#03o", escapeSeq, r)
}
out += string(r)
outSb.WriteString(string(r))
s = s[i+len(escapeSeq)+3:]
}