presubmit: check for uppercase (#1774)

Another thing we can test automatically, we sorta settled on using an
uppercase letter in in t.Log and t.Fatal calls.

Let's just check for this.
This commit is contained in:
Miek Gieben
2018-05-07 22:47:25 +01:00
committed by Yong Tang
parent 15d989e294
commit 643550eabe
25 changed files with 104 additions and 90 deletions

View File

@@ -17,7 +17,7 @@ func TestCacheSet(t *testing.T) {
dnskey, err := ParseKeyFile(fPub, fPriv)
if err != nil {
t.Fatalf("failed to parse key: %v\n", err)
t.Fatalf("Failed to parse key: %v\n", err)
}
c := cache.New(defaultCap)
@@ -29,7 +29,7 @@ func TestCacheSet(t *testing.T) {
_, ok := d.get(k, server)
if !ok {
t.Errorf("signature was not added to the cache")
t.Errorf("Signature was not added to the cache")
}
}
@@ -41,7 +41,7 @@ func TestCacheNotValidExpired(t *testing.T) {
dnskey, err := ParseKeyFile(fPub, fPriv)
if err != nil {
t.Fatalf("failed to parse key: %v\n", err)
t.Fatalf("Failed to parse key: %v\n", err)
}
c := cache.New(defaultCap)
@@ -53,7 +53,7 @@ func TestCacheNotValidExpired(t *testing.T) {
_, ok := d.get(k, server)
if ok {
t.Errorf("signature was added to the cache even though not valid")
t.Errorf("Signature was added to the cache even though not valid")
}
}
@@ -65,7 +65,7 @@ func TestCacheNotValidYet(t *testing.T) {
dnskey, err := ParseKeyFile(fPub, fPriv)
if err != nil {
t.Fatalf("failed to parse key: %v\n", err)
t.Fatalf("Failed to parse key: %v\n", err)
}
c := cache.New(defaultCap)
@@ -77,6 +77,6 @@ func TestCacheNotValidYet(t *testing.T) {
_, ok := d.get(k, server)
if ok {
t.Errorf("signature was added to the cache even though not valid yet")
t.Errorf("Signature was added to the cache even though not valid yet")
}
}