presubmit: check for uppercase (#1774)

Another thing we can test automatically, we sorta settled on using an
uppercase letter in in t.Log and t.Fatal calls.

Let's just check for this.
This commit is contained in:
Miek Gieben
2018-05-07 22:47:25 +01:00
committed by Yong Tang
parent 15d989e294
commit 643550eabe
25 changed files with 104 additions and 90 deletions

View File

@@ -39,7 +39,7 @@ func TestClientQueryResponse(t *testing.T) {
return
}
if l := len(trapper.Trap); l != 2 {
t.Fatalf("%d msg trapped", l)
t.Fatalf("Mmsg %d trapped", l)
return
}
want, err := d.ToClientQuery()
@@ -48,7 +48,7 @@ func TestClientQueryResponse(t *testing.T) {
}
have := trapper.Trap[0]
if !test.MsgEqual(want, have) {
t.Fatalf("query: want: %v\nhave: %v", want, have)
t.Fatalf("Query: want: %v\nhave: %v", want, have)
}
want, err = d.ToClientResponse()
if err != nil {
@@ -56,7 +56,7 @@ func TestClientQueryResponse(t *testing.T) {
}
have = trapper.Trap[1]
if !test.MsgEqual(want, have) {
t.Fatalf("response: want: %v\nhave: %v", want, have)
t.Fatalf("Response: want: %v\nhave: %v", want, have)
}
}