Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-04-05 11:45:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

lint(revive): fix unused-parameter violations (#7980)

Browse Source
This commit is contained in:
Ville Vesilehto
2026-03-30 03:02:20 +03:00
committed by GitHub
parent 6af8fd46fe
commit 6720959b8b
95 changed files with 245 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugin/transfer/select_test.go
View File

@@ -16,14 +16,14 @@ type (
t2 struct{}
)
func (t t1) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) {
func (t t1) Transfer(zone string, _serial uint32) (<-chan []dns.RR, error) {
const z = "example.org."
if zone != z {
return nil, ErrNotAuthoritative
}
return nil, errors.New(z)
}
func (t t2) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) {
func (t t2) Transfer(zone string, _serial uint32) (<-chan []dns.RR, error) {
const z = "sub.example.org."
if zone != z {
return nil, ErrNotAuthoritative

10
plugin/transfer/transfer_test.go
View File

@@ -57,7 +57,7 @@ type terminatingPlugin struct{}
func (*terminatingPlugin) Name() string { return "testplugin" }
// ServeDNS implements plugin.Handler that returns NXDOMAIN for all requests.
func (*terminatingPlugin) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
func (*terminatingPlugin) ServeDNS(_ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
m := new(dns.Msg)
m.SetRcode(r, dns.RcodeNameError)
w.WriteMsg(m)
@@ -284,7 +284,7 @@ type errWriter struct {
test.ResponseWriter
}
func (e *errWriter) WriteMsg(m *dns.Msg) error { return fmt.Errorf("write error") }
func (e *errWriter) WriteMsg(_m *dns.Msg) error { return fmt.Errorf("write error") }
// blockingTransferer produces many records into the channel and signals when done.
type blockingTransferer struct {
@@ -293,10 +293,10 @@ type blockingTransferer struct {
}
func (b *blockingTransferer) Name() string { return "blockingtransferer" }
func (b *blockingTransferer) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
func (b *blockingTransferer) ServeDNS(_ctx context.Context, _w dns.ResponseWriter, _r *dns.Msg) (int, error) {
return 0, nil
}
func (b *blockingTransferer) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) {
func (b *blockingTransferer) Transfer(zone string, _serial uint32) (<-chan []dns.RR, error) {
if zone != b.Zone {
return nil, ErrNotAuthoritative
}
@@ -343,7 +343,7 @@ func TestTransferDrainsProducerOnClientError(t *testing.T) {
type nopHandler struct{}
func (nopHandler) Name() string { return "nop" }
func (nopHandler) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
func (nopHandler) ServeDNS(_ctx context.Context, _w dns.ResponseWriter, _r *dns.Msg) (int, error) {
return dns.RcodeSuccess, nil
}