mirror of
https://github.com/coredns/coredns.git
synced 2025-10-27 08:14:18 -04:00
Implement notifies for transfer plugin (#3972)
* Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * really fix test Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben <miek@miek.nl> * Test correct selection of plugin Signed-off-by: Miek Gieben <miek@miek.nl> * add upstream back in Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * fix test Signed-off-by: Miek Gieben <miek@miek.nl> * properly merge Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
@@ -3,7 +3,7 @@ package transfer
|
||||
import (
|
||||
"github.com/coredns/coredns/core/dnsserver"
|
||||
"github.com/coredns/coredns/plugin"
|
||||
parsepkg "github.com/coredns/coredns/plugin/pkg/parse"
|
||||
"github.com/coredns/coredns/plugin/pkg/parse"
|
||||
"github.com/coredns/coredns/plugin/pkg/transport"
|
||||
|
||||
"github.com/caddyserver/caddy"
|
||||
@@ -17,7 +17,7 @@ func init() {
|
||||
}
|
||||
|
||||
func setup(c *caddy.Controller) error {
|
||||
t, err := parse(c)
|
||||
t, err := parseTransfer(c)
|
||||
|
||||
if err != nil {
|
||||
return plugin.Error("transfer", err)
|
||||
@@ -44,8 +44,7 @@ func setup(c *caddy.Controller) error {
|
||||
return nil
|
||||
}
|
||||
|
||||
func parse(c *caddy.Controller) (*Transfer, error) {
|
||||
|
||||
func parseTransfer(c *caddy.Controller) (*Transfer, error) {
|
||||
t := &Transfer{}
|
||||
for c.Next() {
|
||||
x := &xfr{}
|
||||
@@ -83,14 +82,14 @@ func parse(c *caddy.Controller) (*Transfer, error) {
|
||||
x.to = append(x.to, host)
|
||||
continue
|
||||
}
|
||||
normalized, err := parsepkg.HostPort(host, transport.Port)
|
||||
normalized, err := parse.HostPort(host, transport.Port)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
x.to = append(x.to, normalized)
|
||||
}
|
||||
default:
|
||||
return nil, plugin.Error("transfer", c.Errf("unknown property '%s'", c.Val()))
|
||||
return nil, plugin.Error("transfer", c.Errf("unknown property %q", c.Val()))
|
||||
}
|
||||
}
|
||||
if len(x.to) == 0 {
|
||||
|
||||
Reference in New Issue
Block a user