Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/rewrite: fix domain length validation (#2995)

Browse Source 
* unit test

* fix domain length validation

* code optimization

* remove unit test
This commit is contained in:
Ruslan Drozhdzh
2019-07-12 15:22:45 +03:00
committed by Miek Gieben
parent a5c405f6d7
commit 69a2397bf5
2 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugin/rewrite/rewrite.go
View File

@@ -44,11 +44,10 @@ func (rw Rewrite) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg
for _, rule := range rw.Rules {
switch result := rule.Rewrite(ctx, state); result {
case RewriteDone:
if !validName(state.Req.Question[0].Name) {
x := state.Req.Question[0].Name
log.Errorf("Invalid name after rewrite: %s", x)
if _, ok := dns.IsDomainName(state.Req.Question[0].Name); !ok {
err := fmt.Errorf("invalid name after rewrite: %s", state.Req.Question[0].Name)
state.Req.Question[0] = wr.originalQuestion
return dns.RcodeServerFailure, fmt.Errorf("invalid name after rewrite: %s", x)
return dns.RcodeServerFailure, err
}
respRule := rule.GetResponseRule()
if respRule.Active {