mirror of
https://github.com/coredns/coredns.git
synced 2025-12-16 15:25:11 -05:00
Update client-go to v10.0.0 (Kubernetes 1.13) (#2382)
* Update client-go to v10.0.0 (Kubernetes 1.13) This fix updates client-go to v10.0.0 which matches Kubernetes 1.13 (released several days ago). Other changes in Gopkg.yaml: - Updated apimachinary, api, klog, yaml associated with k8s version go dep will not automatically match the version. - Added [prune] field (otherwise go dep will not prune automatically) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Updated Gopkg.lock Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Updated vendor for client-go v10.0.0 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
14
vendor/github.com/opentracing-contrib/go-observer/.gitignore
generated
vendored
14
vendor/github.com/opentracing-contrib/go-observer/.gitignore
generated
vendored
@@ -1,14 +0,0 @@
|
||||
# Binaries for programs and plugins
|
||||
*.exe
|
||||
*.dll
|
||||
*.so
|
||||
*.dylib
|
||||
|
||||
# Test binary, build with `go test -c`
|
||||
*.test
|
||||
|
||||
# Output of the go coverage tool, specifically when used with LiteIDE
|
||||
*.out
|
||||
|
||||
# Project-local glide cache, RE: https://github.com/Masterminds/glide/issues/736
|
||||
.glide/
|
||||
64
vendor/github.com/opentracing-contrib/go-observer/README.md
generated
vendored
64
vendor/github.com/opentracing-contrib/go-observer/README.md
generated
vendored
@@ -1,64 +0,0 @@
|
||||
# An Observer API for OpenTracing-go Tracers
|
||||
|
||||
OTObserver can be used to watch the span events like StartSpan(),
|
||||
SetOperationName(), SetTag() and Finish(). A need for observers
|
||||
arose when information (metrics) more than just the latency information was
|
||||
required for the spans, in the distributed tracers. But, there can be a lot
|
||||
of metrics in different domains and adding such metrics to any one (client)
|
||||
tracer breaks cross-platform compatibility. There are various ways to
|
||||
avoid such issues, however, an observer pattern is cleaner and provides loose
|
||||
coupling between the packages exporting metrics (on span events) and the
|
||||
tracer.
|
||||
|
||||
This information can be in the form of hardware metrics, RPC metrics,
|
||||
useful metrics exported out of the kernel or other metrics, profiled for a
|
||||
span. These additional metrics can help us in getting better Root-cause
|
||||
analysis. With that being said, its not just for calculation of metrics,
|
||||
it can be used for anything which needs watching the span events.
|
||||
|
||||
## Installation and Usage
|
||||
|
||||
The `otobserver` package provides an API to watch span's events and define
|
||||
callbacks for these events. This API would be a functional option to a
|
||||
tracer constructor that passes an Observer. 3rd party packages (who want to
|
||||
watch the span events) should actually implement this observer API.
|
||||
To do that, first fetch the package using go get :
|
||||
|
||||
```
|
||||
go get -v github.com/opentracing-contrib/go-observer
|
||||
```
|
||||
|
||||
and say :
|
||||
|
||||
```go
|
||||
import "github.com/opentracing-contrib/go-observer"
|
||||
```
|
||||
|
||||
and then, define the required span event callbacks. These registered
|
||||
callbacks would then be called on span events if an observer is created.
|
||||
Tracer may allow registering multiple observers. Have a look at the [jaeger's observer](https://github.com/uber/jaeger-client-go/blob/master/observer.go).
|
||||
|
||||
With the required setup implemented in the backend tracers, packages
|
||||
watching the span events need to implement the observer api defining what
|
||||
they need to do for the observed span events.
|
||||
|
||||
## Span events
|
||||
|
||||
An observer registered with this api, can observe for the following four
|
||||
span events :
|
||||
|
||||
```go
|
||||
StartSpan()
|
||||
SetOperationName()
|
||||
SetTag()
|
||||
Finish()
|
||||
```
|
||||
|
||||
### Tradeoffs
|
||||
|
||||
As noble as our thoughts might be in fetching additional metrics (other than
|
||||
latency) for a span using an observer, there are some overhead costs. Not all
|
||||
observers need to observe all the span events, in which case, we may have
|
||||
to keep some callback functions empty. In effect, we will still call these
|
||||
functions, and that will incur unnecessary overhead. To know more about this
|
||||
and other tradeoffs, see this [discussion](https://github.com/opentracing/opentracing-go/pull/135#discussion_r105497329).
|
||||
Reference in New Issue
Block a user