Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make presubmit actually fail the build (#2013)

Browse Source 
The exit code wasn't properly acted upon in the makefile.
Make filename-hyphen actually return an non-zero exit code.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben
2018-07-30 07:41:52 +01:00
committed by Yong Tang
parent 54ec78c1ba
commit 6e1c02c4ac
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.presubmit/filename-hyphen
View File

@@ -5,5 +5,6 @@ echo "** presubmit/$(basename $0)"
for dir in "$@"; do for dir in "$@"; do
if find $dir | grep '-'; then if find $dir | grep '-'; then
echo "** presubmit/$(basename $0): please use an underscore in filenames instead of a hyphen" echo "** presubmit/$(basename $0): please use an underscore in filenames instead of a hyphen"
exit 1
fi fi
done done

2
Makefile
View File

@@ -81,7 +81,7 @@ pb:
# Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build. # Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build.
.PHONY: presubmit .PHONY: presubmit
presubmit: presubmit:
@for pre in $(MAKEPWD)/.presubmit/* ; do "$$pre" $(PRESUBMIT); done @for pre in $(MAKEPWD)/.presubmit/* ; do "$$pre" $(PRESUBMIT) || exit 1 ; done
.PHONY: clean .PHONY: clean
clean: clean: