mirror of
https://github.com/coredns/coredns.git
synced 2025-10-28 08:44:17 -04:00
Make presubmit actually fail the build (#2013)
The exit code wasn't properly acted upon in the makefile. Make filename-hyphen actually return an non-zero exit code. Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
@@ -5,5 +5,6 @@ echo "** presubmit/$(basename $0)"
|
||||
for dir in "$@"; do
|
||||
if find $dir | grep '-'; then
|
||||
echo "** presubmit/$(basename $0): please use an underscore in filenames instead of a hyphen"
|
||||
exit 1
|
||||
fi
|
||||
done
|
||||
|
||||
2
Makefile
2
Makefile
@@ -81,7 +81,7 @@ pb:
|
||||
# Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build.
|
||||
.PHONY: presubmit
|
||||
presubmit:
|
||||
@for pre in $(MAKEPWD)/.presubmit/* ; do "$$pre" $(PRESUBMIT); done
|
||||
@for pre in $(MAKEPWD)/.presubmit/* ; do "$$pre" $(PRESUBMIT) || exit 1 ; done
|
||||
|
||||
.PHONY: clean
|
||||
clean:
|
||||
|
||||
Reference in New Issue
Block a user