Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-01 10:43:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

Added minimal-responses plugin (#4417)

Browse Source 
* Added minimal-responses plugin

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Removed unnecessary comments

* Updated tests

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Reformated imports

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Updated package name

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Removed  unnecessary comments

Co-authored-by: Miek Gieben <miek@miek.nl>

* Added changes

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* updated

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Updated comment for NextOrFailure

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Updated to test.Case for testing

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* Formated imports using goimports

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

Co-authored-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Soumya Ghosh Dastidar
2021-03-15 20:07:55 +05:30
committed by GitHub
parent 74ef6e00f1
commit 7651e6c4de
9 changed files with 289 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

152
plugin/minimal/minimal_test.go Normal file
View File

@@ -0,0 +1,152 @@
package minimal
import (
"context"
"testing"
"github.com/coredns/coredns/plugin"
"github.com/coredns/coredns/plugin/pkg/dnstest"
"github.com/coredns/coredns/plugin/test"
"github.com/miekg/dns"
)
// testHandler implements plugin.Handler and will be used to create a stub handler for the test
type testHandler struct {
Response *test.Case
Next plugin.Handler
}
func (t *testHandler) Name() string { return "test-handler" }
func (t *testHandler) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
d := new(dns.Msg)
d.SetReply(r)
if t.Response != nil {
d.Answer = t.Response.Answer
d.Ns = t.Response.Ns
d.Extra = t.Response.Extra
d.Rcode = t.Response.Rcode
}
w.WriteMsg(d)
return 0, nil
}
func TestMinimizeResponse(t *testing.T) {
baseAnswer := []dns.RR{
test.A("example.com. 293 IN A 142.250.76.46"),
}
baseNs := []dns.RR{
test.NS("example.com. 157127 IN NS ns2.example.com."),
test.NS("example.com. 157127 IN NS ns1.example.com."),
test.NS("example.com. 157127 IN NS ns3.example.com."),
test.NS("example.com. 157127 IN NS ns4.example.com."),
}
baseExtra := []dns.RR{
test.A("ns2.example.com. 316273 IN A 216.239.34.10"),
test.AAAA("ns2.example.com. 157127 IN AAAA 2001:4860:4802:34::a"),
test.A("ns3.example.com. 316274 IN A 216.239.36.10"),
test.AAAA("ns3.example.com. 157127 IN AAAA 2001:4860:4802:36::a"),
test.A("ns1.example.com. 165555 IN A 216.239.32.10"),
test.AAAA("ns1.example.com. 165555 IN AAAA 2001:4860:4802:32::a"),
test.A("ns4.example.com. 190188 IN A 216.239.38.10"),
test.AAAA("ns4.example.com. 157127 IN AAAA 2001:4860:4802:38::a"),
}
tests := []struct {
active bool
original test.Case
minimal test.Case
}{
{ // minimization possible NoError case
original: test.Case{
Answer: baseAnswer,
Ns: nil,
Extra: baseExtra,
Rcode: 0,
},
minimal: test.Case{
Answer: baseAnswer,
Ns: nil,
Extra: nil,
Rcode: 0,
},
},
{ // delegate response case
original: test.Case{
Answer: nil,
Ns: baseNs,
Extra: baseExtra,
Rcode: 0,
},
minimal: test.Case{
Answer: nil,
Ns: baseNs,
Extra: baseExtra,
Rcode: 0,
},
}, { // negative response case
original: test.Case{
Answer: baseAnswer,
Ns: baseNs,
Extra: baseExtra,
Rcode: 2,
},
minimal: test.Case{
Answer: baseAnswer,
Ns: baseNs,
Extra: baseExtra,
Rcode: 2,
},
},
}
for i, tc := range tests {
req := new(dns.Msg)
req.SetQuestion("example.com", dns.TypeA)
tHandler := &testHandler{
Response: &tc.original,
Next: nil,
}
o := &minimalHandler{Next: tHandler}
rec := dnstest.NewRecorder(&test.ResponseWriter{})
_, err := o.ServeDNS(context.TODO(), rec, req)
if err != nil {
t.Errorf("Expected no error, but got %q", err)
}
if len(tc.minimal.Answer) != len(rec.Msg.Answer) {
t.Errorf("Test %d: Expected %d Answer, but got %d", i, len(tc.minimal.Answer), len(req.Answer))
continue
}
if len(tc.minimal.Ns) != len(rec.Msg.Ns) {
t.Errorf("Test %d: Expected %d Ns, but got %d", i, len(tc.minimal.Ns), len(req.Ns))
continue
}
if len(tc.minimal.Extra) != len(rec.Msg.Extra) {
t.Errorf("Test %d: Expected %d Extras, but got %d", i, len(tc.minimal.Extra), len(req.Extra))
continue
}
for j, a := range rec.Msg.Answer {
if tc.minimal.Answer[j].String() != a.String() {
t.Errorf("Test %d: Expected Answer %d to be %v, but got %v", i, j, tc.minimal.Answer[j], a)
}
}
for j, a := range rec.Msg.Ns {
if tc.minimal.Ns[j].String() != a.String() {
t.Errorf("Test %d: Expected NS %d to be %v, but got %v", i, j, tc.minimal.Ns[j], a)
}
}
for j, a := range rec.Msg.Extra {
if tc.minimal.Extra[j].String() != a.String() {
t.Errorf("Test %d: Expected Extra %d to be %v, but got %v", i, j, tc.minimal.Extra[j], a)
}
}
}
}