Add metrics for cache hits/misses (#375)

* Add metrics for cache hits/misses

Add counters for cache middleware hits and misses.

* Add test for cache middleware hit/miss counters.

* Fix cache hit metric incrementing.

* Add cache hit/miss metrics to dnssec middleware.

* Update README metric documentation.

middleware/cache/README.md

@@ -39,8 +39,12 @@ The minimum TTL allowed on resource records is 5 seconds.
 
 If monitoring is enabled (via the *prometheus* directive) then the following metrics are exported:
 
-* coredns_cache_size{type} - total elements in the case, type is either "denial" or "success".
-* coredns_cache_capacity{type} - total capacity of the cache, type is either "denial" or "success".
+* coredns_cache_size{type} - Total elements in the cache by cache type.
+* coredns_cache_capacity{type} - Total capacity of the cache by cache type.
+* coredns_cache_hits_total{type} - Counter of cache hits by cache type.
+* coredns_cache_misses_total - Counter of cache misses.
+
+Cache types are either "denial" or "success".
 
 ## Examples
 

middleware/cache/handler.go

@@ -44,12 +44,15 @@ func (c *Cache) get(qname string, qtype uint16, do bool) (*item, bool, bool) {
 	k := rawKey(qname, qtype, do)
 
 	if i, ok := c.ncache.Get(k); ok {
+		cacheHits.WithLabelValues(Denial).Inc()
 		return i.(*item), ok, i.(*item).expired(time.Now())
 	}
 
 	if i, ok := c.pcache.Get(k); ok {
+		cacheHits.WithLabelValues(Success).Inc()
 		return i.(*item), ok, i.(*item).expired(time.Now())
 	}
+	cacheMisses.Inc()
 	return nil, false, false
 }
 
@@ -67,6 +70,20 @@ var (
 		Name:      "capacity",
 		Help:      "The cache's capacity.",
 	}, []string{"type"})
+
+	cacheHits = prometheus.NewCounterVec(prometheus.CounterOpts{
+		Namespace: middleware.Namespace,
+		Subsystem: subsystem,
+		Name:      "hits_total",
+		Help:      "The count of cache hits.",
+	}, []string{"type"})
+
+	cacheMisses = prometheus.NewCounter(prometheus.CounterOpts{
+		Namespace: middleware.Namespace,
+		Subsystem: subsystem,
+		Name:      "misses_total",
+		Help:      "The count of cache misses.",
+	})
 )
 
 const subsystem = "cache"
@@ -74,4 +91,6 @@ const subsystem = "cache"
 func init() {
 	prometheus.MustRegister(cacheSize)
 	prometheus.MustRegister(cacheCapacity)
+	prometheus.MustRegister(cacheHits)
+	prometheus.MustRegister(cacheMisses)
 }