Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-30 17:53:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update governance docs to reflect CODEOWNERS (#3491)

Browse Source 
NO GOVERNANCE changes made!

Point to the correct files, now that I merged CODEOWNERS, OWNERS files
are gone and there is also only 1 CODEOWNERS.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben
2019-11-29 16:22:50 +00:00
committed by GitHub
parent b4df2d0d4c
commit 787b6e06f9
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@@ -40,7 +40,7 @@ issue first and "claim" it and get feedback before you invest a lot of time.
**If someone already opened a pull request, but you think the pull request has stalled and you would **If someone already opened a pull request, but you think the pull request has stalled and you would
like to open another pull request for the same or similar feature, get some of the maintainers (see like to open another pull request for the same or similar feature, get some of the maintainers (see
[OWNERS](OWNERS)) involved to resolve the situation and move things forward.** [CODEOWNERS](CODEOWNERS)) involved to resolve the situation and move things forward.**
If possible make a pull request as small as possible, or submit multiple pull request to complete a If possible make a pull request as small as possible, or submit multiple pull request to complete a
feature. Smaller means: easier to understand and review. This in turn means things can be merged feature. Smaller means: easier to understand and review. This in turn means things can be merged

14
GOVERNANCE.md
View File

@@ -22,8 +22,8 @@ The term of the project lead is one year, with no term limit restriction.
The project lead is elected by CoreDNS maintainers The project lead is elected by CoreDNS maintainers
according to an individual's technical merit to CoreDNS project. according to an individual's technical merit to CoreDNS project.
The current project lead is identified in the top level [OWNERS](OWNERS) file with the string The current project lead is identified in the [CODEOWNERS](CODEOWNERS) file with the string
`project lead` and the term behind the name. `project lead` and the term behind the name in a comment at the top of the file.
## Expectations from Maintainers ## Expectations from Maintainers
@@ -35,11 +35,9 @@ participate in Pull Request reviews. Maintainers are expected to respond to assi
in a *reasonable* time frame, either providing insights, or assign the Pull Requests to other in a *reasonable* time frame, either providing insights, or assign the Pull Requests to other
maintainers. maintainers.
Every Maintainer is listed in the top-level [OWNERS](https://github.com/coredns/coredns/blob/master/OWNERS) Every Maintainer is listed in the
file, with their Github handle and a possibly obfuscated email address. Everyone in the [CODEOWNERS](https://github.com/coredns/coredns/blob/master/CODEOWNERS)
`approvers` list is a Maintainer. file, with their Github handle.
A Maintainer is also listed in a plugin specific OWNERS file.
A Maintainer should be a member of `maintainers@coredns.io`, although this is not a hard requirement. A Maintainer should be a member of `maintainers@coredns.io`, although this is not a hard requirement.
@@ -66,7 +64,7 @@ Changes in project lead or term is initiated by opening a github PR.
Anyone from CoreDNS community can vote on the PR with either +1 or -1. Anyone from CoreDNS community can vote on the PR with either +1 or -1.
Only the following votes are binding: Only the following votes are binding:
1) Any maintainer that has been listed in the top-level [OWNERS](OWNERS) file before the PR is opened. 1) Any maintainer that has been listed in the [CODEOWNERS](CODEOWNERS) file before the PR is opened.
2) Any maintainer from an organization may cast the vote for that organization. However, no organization 2) Any maintainer from an organization may cast the vote for that organization. However, no organization
should have more binding votes than 1/5 of the total number of maintainers defined in 1). should have more binding votes than 1/5 of the total number of maintainers defined in 1).