From 7a507e34ca880344dfc98b6331508c0e9bef54f5 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Wed, 25 Apr 2018 12:38:04 +0100 Subject: [PATCH] deprecate some stuff (#1732) https_google and reverse will be removed in 2 releases. Add warnings. We will move reverse to coredns/reverse and list it as external after this switch. See #1713 --- plugin/proxy/google.go | 3 +++ plugin/reverse/setup.go | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/plugin/proxy/google.go b/plugin/proxy/google.go index 2c265ba4f..0dbca6383 100644 --- a/plugin/proxy/google.go +++ b/plugin/proxy/google.go @@ -27,6 +27,9 @@ type google struct { } func newGoogle(endpoint string, bootstrap []string) *google { + // TODO(miek): Deprecate after 1.1.3 (that would be 1.2.0) + log.Warning("https_google will be deprecated in the next release") + if endpoint == "" { endpoint = ghost } diff --git a/plugin/reverse/setup.go b/plugin/reverse/setup.go index d6fc841ad..1033a0de4 100644 --- a/plugin/reverse/setup.go +++ b/plugin/reverse/setup.go @@ -10,10 +10,13 @@ import ( "github.com/coredns/coredns/core/dnsserver" "github.com/coredns/coredns/plugin" "github.com/coredns/coredns/plugin/pkg/fall" + clog "github.com/coredns/coredns/plugin/pkg/log" "github.com/mholt/caddy" ) +var log = clog.NewWithPlugin("reverse") + func init() { caddy.RegisterPlugin("reverse", caddy.Plugin{ ServerType: "dns", @@ -31,6 +34,9 @@ func setup(c *caddy.Controller) error { return Reverse{Next: next, Networks: networks, Fall: fall} }) + // TODO(miek): Deprecate after 1.1.3 (that would be 1.2.0) + log.Warning("reverse will be deprecated in the next release") + return nil }