Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 08:44:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/kubernetes: Validate transfers are allowed (#2292)

Browse Source 
* check allowed transfers

* add tests for parsing, and comment about refactor
This commit is contained in:
Chris O'Haver
2018-11-13 18:25:30 -05:00
committed by Miek Gieben
parent 4d52a71f09
commit 7aafbe24ca
3 changed files with 105 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
plugin/kubernetes/xfr_test.go
View File

@@ -15,7 +15,7 @@ import (
func TestKubernetesXFR(t *testing.T) {
k := New([]string{"cluster.local."})
k.APIConn = &APIConnServeTest{}
k.TransferTo = []string{"127.0.0.1"}
k.TransferTo = []string{"10.240.0.1:53"}
k.Namespaces = map[string]bool{"testns": true}
ctx := context.TODO()
@@ -30,7 +30,12 @@ func TestKubernetesXFR(t *testing.T) {
if len(w.Msgs) == 0 {
t.Logf("%+v\n", w)
t.Error("Did not get back a zone response")
t.Fatal("Did not get back a zone response")
}
if len(w.Msgs[0].Answer) == 0 {
t.Logf("%+v\n", w)
t.Fatal("Did not get back an answer")
}
// Ensure xfr starts with SOA
@@ -95,6 +100,33 @@ func TestKubernetesXFR(t *testing.T) {
}
}
func TestKubernetesXFRNotAllowed(t *testing.T) {
k := New([]string{"cluster.local."})
k.APIConn = &APIConnServeTest{}
k.TransferTo = []string{"1.2.3.4:53"}
k.Namespaces = map[string]bool{"testns": true}
ctx := context.TODO()
w := dnstest.NewMultiRecorder(&test.ResponseWriter{})
dnsmsg := &dns.Msg{}
dnsmsg.SetAxfr(k.Zones[0])
_, err := k.ServeDNS(ctx, w, dnsmsg)
if err != nil {
t.Error(err)
}
if len(w.Msgs) == 0 {
t.Logf("%+v\n", w)
t.Fatal("Did not get back a zone response")
}
if len(w.Msgs[0].Answer) != 0 {
t.Logf("%+v\n", w)
t.Fatal("Got an answer, should not have")
}
}
// difference shows what we're missing when comparing two RR slices
func difference(testRRs []dns.RR, gotRRs []dns.RR) []dns.RR {
expectedRRs := map[string]bool{}