mirror of
https://github.com/coredns/coredns.git
synced 2026-01-12 03:41:18 -05:00
plugin: fix gosec G115 integer overflow warnings (#7799)
Fix integer overflow conversion warnings (G115) by adding appropriate suppressions where values are provably bounded. Fixes: https://github.com/coredns/coredns/issues/7793 Changes: - Updated 56 G115 annotations to use consistent // #nosec G115 format - Added 2 //nolint:gosec suppressions for conditional expressions - Removed G115 exclusion from golangci.yml (now explicitly handled per-line) Suppressions justify why each conversion is safe (e.g., port numbers are bounded 1-65535, DNS TTL limits, pool lengths, etc.) Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
This commit is contained in:
@@ -44,7 +44,7 @@ func (s *Signer) Sign(now time.Time) (*file.Zone, error) {
|
||||
mttl := z.SOA.Minttl
|
||||
ttl := z.SOA.Header().Ttl
|
||||
inception, expiration := lifetime(now, s.jitterIncep, s.jitterExpir)
|
||||
z.SOA.Serial = uint32(now.Unix())
|
||||
z.SOA.Serial = uint32(now.Unix()) // #nosec G115 -- Unix time to SOA serial, Year 2106 problem accepted
|
||||
|
||||
for _, pair := range s.keys {
|
||||
pair.Public.Header().Ttl = ttl // set TTL on key so it matches the RRSIG.
|
||||
@@ -200,7 +200,7 @@ func (s *Signer) refresh(val time.Duration) {
|
||||
}
|
||||
|
||||
func lifetime(now time.Time, jitterInception, jitterExpiration time.Duration) (uint32, uint32) {
|
||||
incep := uint32(now.Add(durationSignatureInceptionHours).Add(jitterInception).Unix())
|
||||
expir := uint32(now.Add(durationSignatureExpireDays).Add(jitterExpiration).Unix())
|
||||
incep := uint32(now.Add(durationSignatureInceptionHours).Add(jitterInception).Unix()) // #nosec G115 -- DNSSEC signature inception, Year 2106 problem accepted
|
||||
expir := uint32(now.Add(durationSignatureExpireDays).Add(jitterExpiration).Unix()) // #nosec G115 -- DNSSEC signature expiration, Year 2106 problem accepted
|
||||
return incep, expir
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user