Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-06 03:56:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

mw/health: call Shutdown on FinalShutdown (#1003)

Browse Source 
Reloading caddy won't kill the health handler. Only on final shutdown
we stop the handler.

Currently when reloading CoreDNS with -SIGUSR1 the health handler stops
answering - there is a test for this but it doesn't capture whole
process reloading, sadly. This PR keeps the handler alive during reloads
and only stops on process shutdown.
This commit is contained in:
Miek Gieben
2017-08-29 21:23:13 +02:00
committed by GitHub
parent 7e63bdbee8
commit 7b8cf9df90
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
middleware/health/setup.go
View File

@@ -47,7 +47,7 @@ func setup(c *caddy.Controller) error {
}) })
c.OnStartup(h.Startup) c.OnStartup(h.Startup)
c.OnShutdown(h.Shutdown) c.OnFinalShutdown(h.Shutdown)
// Don't do AddMiddleware, as health is not *really* a middleware just a separate webserver running. // Don't do AddMiddleware, as health is not *really* a middleware just a separate webserver running.
return nil return nil