Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 00:34:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/proxy: when HC fails increase fails (#1270)

Browse Source 
When we failing the healthcheck we should increate the fails for this
host; which is the *bleeping* point of doing the HC in the first place.

Add the missing atomic.Adds.

Fixes #1247
This commit is contained in:
Miek Gieben
2017-12-01 15:57:34 +00:00
committed by GitHub
parent 0d103ff57c
commit 7cc3b08f65
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/pkg/healthcheck/healthcheck.go
View File

@@ -123,6 +123,7 @@ func (uh *UpstreamHost) HealthCheckURL() {
if err != nil { if err != nil {
log.Printf("[WARNING] Host %s health check probe failed: %v", uh.Name, err) log.Printf("[WARNING] Host %s health check probe failed: %v", uh.Name, err)
atomic.AddInt32(&uh.Fails, 1)
return return
} }
@@ -132,6 +133,7 @@ func (uh *UpstreamHost) HealthCheckURL() {
if r.StatusCode < 200 || r.StatusCode >= 400 { if r.StatusCode < 200 || r.StatusCode >= 400 {
log.Printf("[WARNING] Host %s health check returned HTTP code %d", uh.Name, r.StatusCode) log.Printf("[WARNING] Host %s health check returned HTTP code %d", uh.Name, r.StatusCode)
atomic.AddInt32(&uh.Fails, 1)
return return
} }