Cleanup yaml formatting (#5151)

* Add yamllint config.
* Add yamllint workflow.
* Cleanup linting issues.
* Remove unnecessary `set -x -e` from workflows.

Signed-off-by: SuperQ <superq@gmail.com>

.circleci/config.yml

@@ -47,7 +47,7 @@ jobs:
       - checkout
       - run:
           name: Get CI repo
-          command : |
+          command: |
             mkdir -p ~/go/src/${CIRCLE_PROJECT_USERNAME}/ci
             git clone https://github.com/${CIRCLE_PROJECT_USERNAME}/ci ~/go/src/${CIRCLE_PROJECT_USERNAME}/ci
       - <<: *setupKubernetes

.github/workflows/go.coverage.yml

@@ -5,7 +5,6 @@ jobs:
     name: Coverage
     runs-on: ubuntu-latest
     steps:
-
       - name: Install Go
         uses: actions/setup-go@v2
         with:

.github/workflows/go.fmt.yml

@@ -8,23 +8,22 @@ jobs:
   fix:
     runs-on: ubuntu-latest
     steps:
-      -
+      - name: Checkout
-        name: Checkout
         uses: actions/checkout@v2
-      -
+
-        name: Fmt
+      - name: Fmt
         run: |
           find . -not -path '*/\.git/*' -type f -name '*.go' -exec gofmt -s -w {} \+
-      -
+
-        name: Set up Git
+      - name: Set up Git
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git config user.name "coredns[bot]"
           git config user.email "bot@bot.coredns.io"
           git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
-      -
+
-        name: Commit and push changes
+      - name: Commit and push changes
         run: |
           git add .
           if output=$(git status --porcelain) && [ ! -z "$output" ]; then

.github/workflows/go.test.yml

@@ -5,7 +5,6 @@ jobs:
     name: Test
     runs-on: ubuntu-latest
     steps:
-
       - name: Install Go
         uses: actions/setup-go@v2
         with:
@@ -28,7 +27,6 @@ jobs:
     name: Test Plugins
     runs-on: ubuntu-latest
     steps:
-
       - name: Install Go
         uses: actions/setup-go@v2
         with:
@@ -48,7 +46,6 @@ jobs:
     name: Test e2e
     runs-on: ubuntu-latest
     steps:
-
       - name: Install Go
         uses: actions/setup-go@v2
         with:
@@ -70,10 +67,8 @@ jobs:
     name: Test Makefile.release
     runs-on: ubuntu-latest
     steps:
-
       - name: Install dependencies
-      run: |
+        run: sudo apt-get install make curl
-        sudo apt-get install make curl
 
       - name: Check out code
         uses: actions/checkout@v2

.github/workflows/go.tidy.yml

@@ -8,30 +8,29 @@ jobs:
   fix:
     runs-on: ubuntu-latest
     steps:
-      -
+      - name: Install Go
-        name: Install Go
         uses: actions/setup-go@v2
         with:
           go-version: '1.17.0'
         id: go
-      -
+
-        name: Checkout
+      - name: Checkout
         uses: actions/checkout@v2
-      -
+
-        name: Tidy
+      - name: Tidy
         run: |
           rm -f go.sum
           go mod tidy
-      -
+
-        name: Set up Git
+      - name: Set up Git
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git config user.name "coredns[bot]"
           git config user.email "bot@bot.coredns.io"
           git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
-      -
+
-        name: Commit and push changes
+      - name: Commit and push changes
         run: |
           git add .
           if output=$(git status --porcelain) && [ ! -z "$output" ]; then

.github/workflows/make.doc.yml

@@ -8,31 +8,29 @@ jobs:
   fix:
     runs-on: ubuntu-latest
     steps:
-      -
+      - name: Checkout
-        name: Checkout
         uses: actions/checkout@v2
-      -
+
-        name: Setup Go
+      - name: Setup Go
         uses: actions/setup-go@v2
         with:
           go-version: '1.17.0'
-      -
+
-        name: Update Docs
+      - name: Update Docs
         run: |
           bash -x -e ./.github/fixup_file_mtime.sh
           make -f Makefile.doc
-      -
+
-        name: Set up Git
+      - name: Set up Git
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git config user.name "coredns[bot]"
           git config user.email "bot@bot.coredns.io"
           git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
-      -
+
-        name: Commit and push changes
+      - name: Commit and push changes
         run: |
-          set -x -e
           git add .
           if output=$(git status --porcelain) && [ ! -z "$output" ]; then
             git commit -s -m 'auto make -f Makefile.doc'

.github/workflows/whitespace.yml

@@ -8,23 +8,22 @@ jobs:
   fix:
     runs-on: ubuntu-latest
     steps:
-      -
+      - name: Checkout
-        name: Checkout
         uses: actions/checkout@v2
-      -
+
-        name: Remove Trailing Whitespaces
+      - name: Remove Trailing Whitespaces
         run: |
           find . -not -path '*/\.git/*' -type f -not -name '*.go' -exec sed -i 's/[[:space:]]\{1,\}$//' {} \+
-      -
+
-        name: Set up Git
+      - name: Set up Git
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git config user.name "coredns[bot]"
           git config user.email "bot@bot.coredns.io"
           git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
-      -
+
-        name: Commit and push changes
+      - name: Commit and push changes
         run: |
           git add .
           if output=$(git status --porcelain) && [ ! -z "$output" ]; then

.github/workflows/yamllint.yml

@@ -0,0 +1,18 @@
+name: 'Yamllint GitHub Actions'
+on:
+  - pull_request
+jobs:
+  yamllint:
+    name: 'Yamllint'
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/checkout@master
+      - name: 'Yamllint'
+        uses: karancode/yamllint-github-action@master
+        with:
+          yamllint_file_or_dir: '.'
+          yamllint_strict: false
+          yamllint_comment: true
+        env:
+          GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.yamllint

@@ -0,0 +1,17 @@
+---
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+    level: error
+  brackets:
+    max-spaces-inside: 1
+    level: error
+  document-start: disable
+  hyphens:
+    max-spaces-after: 1
+  indentation:
+    spaces: 2
+  line-length: disable
+  truthy: disable