mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 18:23:13 -04:00 
			
		
		
		
	Cache elements of State
Cache the size and the do bit whenever someone asked for it. We can probably add more: PASS BenchmarkStateDo-4 100000000 11.9 ns/op BenchmarkStateSize-4 5000000 265 ns/op ok github.com/miekg/coredns/middleware 2.828s PASS BenchmarkStateDo-4 1000000000 2.86 ns/op BenchmarkStateSize-4 500000000 3.10 ns/op ok github.com/miekg/coredns/middleware 5.032s This PR also includes some testing cleanups as well.
This commit is contained in:
		| @@ -16,9 +16,9 @@ import ( | ||||
| 	"github.com/miekg/coredns/middleware/etcd/singleflight" | ||||
| 	"github.com/miekg/coredns/middleware/proxy" | ||||
| 	coretest "github.com/miekg/coredns/middleware/testing" | ||||
| 	"github.com/miekg/dns" | ||||
|  | ||||
| 	etcdc "github.com/coreos/etcd/client" | ||||
| 	"github.com/miekg/dns" | ||||
| 	"golang.org/x/net/context" | ||||
| ) | ||||
|  | ||||
| @@ -67,7 +67,7 @@ func TestLookup(t *testing.T) { | ||||
| 	for _, tc := range dnsTestCases { | ||||
| 		m := tc.Msg() | ||||
|  | ||||
| 		rec := middleware.NewResponseRecorder(&middleware.TestResponseWriter{}) | ||||
| 		rec := middleware.NewResponseRecorder(&coretest.ResponseWriter{}) | ||||
| 		_, err := etc.ServeDNS(ctx, rec, m) | ||||
| 		if err != nil { | ||||
| 			t.Errorf("expected no error, got %v\n", err) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user