Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-09-05 03:27:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/minimal: Fixes a nil pointer dereference panic in minimal prefetch response processing (#8506)

Browse Source 
* plugin/minimal: Fixes a nil pointer dereference panic in minimal prefetch response processing

This PR fixes a nil pointer dereference panic in minimal prefetch response processing

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Fix lint

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

---------

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang
2026-09-02 07:58:49 -07:00
committed by GitHub
parent a87f9efcc5
commit 88ab058ba2
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugin/minimal/minimal.go
View File

@@ -26,6 +26,9 @@ func (m *minimalHandler) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *
if err != nil { if err != nil {
return rcode, err return rcode, err
} }
if nw.Msg == nil {
return rcode, nil
}
ty, _ := response.Typify(nw.Msg, time.Now().UTC()) ty, _ := response.Typify(nw.Msg, time.Now().UTC())
cl := response.Classify(ty) cl := response.Classify(ty)

17
plugin/minimal/minimal_test.go
View File

@@ -151,3 +151,20 @@ func TestMinimizeResponse(t *testing.T) {
} }
} }
} }
func TestMinimizeResponseNilMsgPanic(t *testing.T) {
nilMsgHandler := plugin.HandlerFunc(func(_ context.Context, w dns.ResponseWriter, _ *dns.Msg) (int, error) {
w.WriteMsg(nil)
return 0, nil
})
o := minimalHandler{Next: nilMsgHandler}
rec := dnstest.NewRecorder(&test.ResponseWriter{})
req := new(dns.Msg)
req.SetQuestion("example.com.", dns.TypeA)
_, err := o.ServeDNS(context.TODO(), rec, req)
if err != nil {
t.Fatalf("Expected no error, got %v", err)
}
}