Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-29 17:24:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix some typos (#2560)

Browse Source 
* Fix some typos

Corect some words for reading more easily

* Update NOERROR response code

NOERROR is a response code so I revert the typo checking for it
This commit is contained in:
Nguyen Quang Huy
2019-02-17 15:31:12 +07:00
committed by Miek Gieben
parent 871bce3a23
commit 8d09cb243f
9 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/backend_lookup.go
View File

@@ -438,7 +438,7 @@ func newAddress(s msg.Service, name string, ip net.IP, what uint16) dns.RR {
return &dns.AAAA{Hdr: hdr, AAAA: ip} return &dns.AAAA{Hdr: hdr, AAAA: ip}
} }
// checkForApex checks the spcecial apex.dns directory for records that will be returned as A or AAAA. // checkForApex checks the special apex.dns directory for records that will be returned as A or AAAA.
func checkForApex(b ServiceBackend, zone string, state request.Request, opt Options) ([]msg.Service, error) { func checkForApex(b ServiceBackend, zone string, state request.Request, opt Options) ([]msg.Service, error) {
if state.Name() != zone { if state.Name() != zone {
return b.Services(state, false, opt) return b.Services(state, false, opt)

2
plugin/cache/README.md vendored
View File

@@ -19,7 +19,7 @@ cache [TTL] [ZONES...]
~~~ ~~~
* **TTL** max TTL in seconds. If not specified, the maximum TTL will be used, which is 3600 for * **TTL** max TTL in seconds. If not specified, the maximum TTL will be used, which is 3600 for
noerror responses and 1800 for denial of existence ones. NOERROR responses and 1800 for denial of existence ones.
Setting a TTL of 300: `cache 300` would cache records up to 300 seconds. Setting a TTL of 300: `cache 300` would cache records up to 300 seconds.
* **ZONES** zones it should cache for. If empty, the zones from the configuration block are used. * **ZONES** zones it should cache for. If empty, the zones from the configuration block are used.

2
plugin/cache/cache.go vendored
View File

@@ -118,7 +118,7 @@ type ResponseWriter struct {
// newPrefetchResponseWriter returns a Cache ResponseWriter to be used in // newPrefetchResponseWriter returns a Cache ResponseWriter to be used in
// prefetch requests. It ensures RemoteAddr() can be called even after the // prefetch requests. It ensures RemoteAddr() can be called even after the
// original connetion has already been closed. // original connection has already been closed.
func newPrefetchResponseWriter(server string, state request.Request, c *Cache) *ResponseWriter { func newPrefetchResponseWriter(server string, state request.Request, c *Cache) *ResponseWriter {
// Resolve the address now, the connection might be already closed when the // Resolve the address now, the connection might be already closed when the
// actual prefetch request is made. // actual prefetch request is made.

2
plugin/dnssec/black_lies.go
View File

@@ -7,7 +7,7 @@ import (
"github.com/miekg/dns" "github.com/miekg/dns"
) )
// nsec returns an NSEC useful for NXDOMAIN respsones. // nsec returns an NSEC useful for NXDOMAIN responses.
// See https://tools.ietf.org/html/draft-valsorda-dnsop-black-lies-00 // See https://tools.ietf.org/html/draft-valsorda-dnsop-black-lies-00
// For example, a request for the non-existing name a.example.com would // For example, a request for the non-existing name a.example.com would
// cause the following NSEC record to be generated: // cause the following NSEC record to be generated:

2
plugin/etcd/README.md
View File

@@ -61,7 +61,7 @@ etcd [ZONES...] {
## Special Behaviour ## Special Behaviour
CoreDNS etcd plugin leverages directory structure to look for related entries. For example an entry `/skydns/test/skydns/mx` would have entries like `/skydns/test/skydns/mx/a`, `/skydns/test/skydns/mx/b` and so on. Similarly a directory `/skydns/test/skydns/mx1` will have all `mx1` entries. CoreDNS etcd plugin leverages directory structure to look for related entries. For example an entry `/skydns/test/skydns/mx` would have entries like `/skydns/test/skydns/mx/a`, `/skydns/test/skydns/mx/b` and so on. Similarly a directory `/skydns/test/skydns/mx1` will have all `mx1` entries.
With etcd3, support for [hierarchial keys are dropped](https://coreos.com/etcd/docs/latest/learning/api.html). This means there are no directories but only flat keys with prefixes in etcd3. To accommodate lookups, etcdv3 plugin now does a lookup on prefix `/skydns/test/skydns/mx/` to search for entries like `/skydns/test/skydns/mx/a` etc, and if there is nothing found on `/skydns/test/skydns/mx/`, it looks for `/skydns/test/skydns/mx` to find entries like `/skydns/test/skydns/mx1`. With etcd3, support for [hierarchical keys are dropped](https://coreos.com/etcd/docs/latest/learning/api.html). This means there are no directories but only flat keys with prefixes in etcd3. To accommodate lookups, etcdv3 plugin now does a lookup on prefix `/skydns/test/skydns/mx/` to search for entries like `/skydns/test/skydns/mx/a` etc, and if there is nothing found on `/skydns/test/skydns/mx/`, it looks for `/skydns/test/skydns/mx` to find entries like `/skydns/test/skydns/mx1`.
This causes two lookups from CoreDNS to etcdv3 in certain cases. This causes two lookups from CoreDNS to etcdv3 in certain cases.

4
plugin/hosts/README.md
View File

@@ -55,8 +55,8 @@ hosts [FILE [ZONES...]] {
are used. are used.
* **INLINE** the hosts file contents inlined in Corefile. If there are any lines before fallthrough * **INLINE** the hosts file contents inlined in Corefile. If there are any lines before fallthrough
then all of them will be treated as the additional content for hosts file. The specified hosts then all of them will be treated as the additional content for hosts file. The specified hosts
file path will still be read but entries will be overrided. file path will still be read but entries will be overridden.
* `ttl` change the DNS TTL of the records generated (forward and reverse). The default is 3600 seonds (1 hour). * `ttl` change the DNS TTL of the records generated (forward and reverse). The default is 3600 seconds (1 hour).
* `reload` change the period between each hostsfile reload. A time of zero seconds disable the feature. Examples of valid durations: "300ms", "1.5h" or "2h45m" are valid duration with units "ns" (nanosecond), "us" (or "µs" for microsecond), "ms" (millisecond), "s" (second), "m" (minute), "h" (hour). * `reload` change the period between each hostsfile reload. A time of zero seconds disable the feature. Examples of valid durations: "300ms", "1.5h" or "2h45m" are valid duration with units "ns" (nanosecond), "us" (or "µs" for microsecond), "ms" (millisecond), "s" (second), "m" (minute), "h" (hour).
* `no_reverse` disable the automatic generation of the the `in-addr.arpa` or `ip6.arpa` entries for the hosts * `no_reverse` disable the automatic generation of the the `in-addr.arpa` or `ip6.arpa` entries for the hosts
* `fallthrough` If zone matches and no record can be generated, pass request to the next plugin. * `fallthrough` If zone matches and no record can be generated, pass request to the next plugin.

2
plugin/kubernetes/controller.go
View File

@@ -47,7 +47,7 @@ type dnsController interface {
type dnsControl struct { type dnsControl struct {
// Modified tracks timestamp of the most recent changes // Modified tracks timestamp of the most recent changes
// It needs to be first because it is guarnteed to be 8-byte // It needs to be first because it is guaranteed to be 8-byte
// aligned ( we use sync.LoadAtomic with this ) // aligned ( we use sync.LoadAtomic with this )
modified int64 modified int64

2
plugin/rewrite/README.md
View File

@@ -175,7 +175,7 @@ rewrite [continue|stop] {
Note that the above syntax is strict. For response rewrites only `name` Note that the above syntax is strict. For response rewrites only `name`
rules are allowed to match the question section, and only by match type rules are allowed to match the question section, and only by match type
`regex`. The answer rewrite must be after the name, as ordered in the `regex`. The answer rewrite must be after the name, as ordered in the
syntax example. There must only be two lines (a `name` follwed by an syntax example. There must only be two lines (a `name` followed by an
`answer`) in the brackets, additional rules are not supported. `answer`) in the brackets, additional rules are not supported.
An alternate syntax for the rewrite of DNS request and response is as An alternate syntax for the rewrite of DNS request and response is as

2
request/writer.go
View File

@@ -11,7 +11,7 @@ type ScrubWriter struct {
// NewScrubWriter returns a new and initialized ScrubWriter. // NewScrubWriter returns a new and initialized ScrubWriter.
func NewScrubWriter(req *dns.Msg, w dns.ResponseWriter) *ScrubWriter { return &ScrubWriter{w, req} } func NewScrubWriter(req *dns.Msg, w dns.ResponseWriter) *ScrubWriter { return &ScrubWriter{w, req} }
// WriteMsg overrides the default implementation of the underlaying dns.ResponseWriter and calls // WriteMsg overrides the default implementation of the underlying dns.ResponseWriter and calls
// scrub on the message m and will then write it to the client. // scrub on the message m and will then write it to the client.
func (s *ScrubWriter) WriteMsg(m *dns.Msg) error { func (s *ScrubWriter) WriteMsg(m *dns.Msg) error {
state := Request{Req: s.req, W: s.ResponseWriter} state := Request{Req: s.req, W: s.ResponseWriter}