From 8faca26873baf063480793b00eebdd8121ce3229 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Thu, 18 Mar 2021 15:39:40 +0100 Subject: [PATCH] plugin/bind: tweak error messages (#4532) When the interface doesn't exist you get: plugin/bind: not a valid IP address: eth0 Fix the wording that this can also be interface name. Also %q the argument in the error mesg. Signed-off-by: Miek Gieben --- plugin/bind/setup.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin/bind/setup.go b/plugin/bind/setup.go index b2a37551c..d75d6c0ff 100644 --- a/plugin/bind/setup.go +++ b/plugin/bind/setup.go @@ -33,7 +33,7 @@ func setup(c *caddy.Controller) error { isIface = true addrs, err := iface.Addrs() if err != nil { - return plugin.Error("bind", fmt.Errorf("failed to get the IP(s) of the interface: %s", arg)) + return plugin.Error("bind", fmt.Errorf("failed to get the IP addresses of the interface: %q", arg)) } for _, addr := range addrs { if ipnet, ok := addr.(*net.IPNet); ok { @@ -46,7 +46,7 @@ func setup(c *caddy.Controller) error { } if !isIface { if net.ParseIP(arg) == nil { - return plugin.Error("bind", fmt.Errorf("not a valid IP address: %s", arg)) + return plugin.Error("bind", fmt.Errorf("not a valid IP address or interface name: %q", arg)) } all = append(all, arg) }